Explain how to consume changes in PointerInputScope.detectDragGestures and frieds [185096350]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Apr 12, 2021 10:20AM

We need to explain how to consume changes in those functions, why it's important and what will happen if you don't do it.

Comments

au...@google.com <au...@google.com> #2Apr 12, 2021 05:32PM

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

ma...@google.com <ma...@google.com> #3Apr 12, 2021 05:54PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

lp...@google.com <lp...@google.com> #4Apr 12, 2021 06:02PM

#2, yeah, that's the same issue.

au...@google.com <au...@google.com> #5Apr 12, 2021 06:21PM

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

ma...@google.com <ma...@google.com> #6Apr 14, 2021 01:36PM

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

ap...@google.com <ap...@google.com> #7May 20, 2021 12:18PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-beta01
androidx.compose.foundation:foundation-android:1.8.0-beta01
androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

ma...@google.com <ma...@google.com> #8May 20, 2021 12:20PM

Made is so we always consume, the explicit consumption is no longer required and the usage of those functions should be easier now.

Thanks again Aurimas for the report!

au...@google.com <au...@google.com> #9May 20, 2021 07:29PM

This is awesome, thanks for making this change as it will be a lot easier to do the right thing!

pa...@gmail.com <pa...@gmail.com> #10May 29, 2024 03:43PM

This change should have be optional! I have a usecase where i want to be able to detectdraggestures and at the same time lets other composables be focusable or detect if theyre being hovered over. this is currently impossible and we have to use large workarounds that affect performance to achieve this same behaviour. I domnt know if there is not another way of implementing this usecase without creating a lot of code that could have been imnplemented if this issue hadnt been "fixed"