Fixed
Status Update
No update yet.
Comments
bo...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
gy...@google.com
gy...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit bc89e5d7c7785b0c4ea4842fe73a1e1324b6ea33
Author: Gyumin Sim <gyumin@google.com>
Date: Mon Sep 27 15:41:38 2021
Remove intent query element from manifest of media
It makes the package visibility filter opted-in by users rather than
automatically by the library.
It partially reverts If2a46bce0cdc78750d08eec66488fe3150610e5b.
Bug: 185314633
Relnote: "The library won't inject the package visibility filter for
`MediaBrowserCompat` anymore. Please specify a `<queries>` element
in your apps manifest when targeting API level 30 or higher."
Test: ./media/version-compat-tests/runtest.sh 4 on API 30
Change-Id: I0a964e51887211650279b9bd1efd79ce4c5bb5c2
M media/media/src/main/java/android/support/v4/media/MediaBrowserCompat.java
M media/media/src/main/AndroidManifest.xml
https://android-review.googlesource.com/1836874
Branch: androidx-main
commit bc89e5d7c7785b0c4ea4842fe73a1e1324b6ea33
Author: Gyumin Sim <gyumin@google.com>
Date: Mon Sep 27 15:41:38 2021
Remove intent query element from manifest of media
It makes the package visibility filter opted-in by users rather than
automatically by the library.
It partially reverts If2a46bce0cdc78750d08eec66488fe3150610e5b.
Bug: 185314633
Relnote: "The library won't inject the package visibility filter for
`MediaBrowserCompat` anymore. Please specify a `<queries>` element
in your apps manifest when targeting API level 30 or higher."
Test: ./media/version-compat-tests/runtest.sh 4 on API 30
Change-Id: I0a964e51887211650279b9bd1efd79ce4c5bb5c2
M media/media/src/main/java/android/support/v4/media/MediaBrowserCompat.java
M media/media/src/main/AndroidManifest.xml
gy...@google.com
I'm expecting the fix for androidx.media will be released with the version 1.4.3 targeting October 14th.
Description
Component used: androidx.media
Version used: 1.3.0
Devices/Android versions reproduced on: N/A
After updating androidx.media:media from 1.2.1 to 1.3.0, we see this additional entry in our generated app manifest:
We use this library to be able to intercept the media button. We don't need to query activities that support the MediaBrowserService intent.
I know I can remove this by adding the following to my app's manifest, but it would be great if this library didn't automatically add this to the manifest.
Thanks!