androidx.media library 1.3.0 adds android.media.browse.MediaBrowserService intent query to manifest [185314633]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 14, 2021 04:11PM

Component used: androidx.media

Version used: 1.3.0

Devices/Android versions reproduced on: N/A

After updating androidx.media:media from 1.2.1 to 1.3.0, we see this additional entry in our generated app manifest:

<queries>
    <intent>
        <action android:name="android.media.browse.MediaBrowserService" />
    </intent>
</queries>

We use this library to be able to intercept the media button. We don't need to query activities that support the MediaBrowserService intent.

I know I can remove this by adding the following to my app's manifest, but it would be great if this library didn't automatically add this to the manifest.

<queries>
  <intent tools:node="remove">
    <action android:name="android.media.browse.MediaBrowserService" />
  </intent>
</queries>

Thanks!

Comments

bo...@google.com <bo...@google.com> #2Apr 14, 2021 04:17PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

gy...@google.com <gy...@google.com> #3Apr 15, 2021 01:43AM

Status: Won't Fix (Intended Behavior)

Thank you for filing this bug. The intent filter element is added to queries for developer's convenience who wants to use MediaBrowser targetting Android 11 (https://developer.android.com/training/package-visibility/use-cases#connect-to-media-browser-services). I understand all users of "androidx.media" actually need it but adding the intent filter by default looks reasonable for convenience unless there would be critical side-effect. Please feel free to re-open it if any concerns.

gy...@google.com <gy...@google.com> Sep 27, 2021 06:30AM

Accepted by gy...@google.com.

ap...@google.com <ap...@google.com> #4Sep 28, 2021 08:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit bdcf20ccfe86deb50337184444d7660ad2745916
Author: Gyumin Sim <gyumin@google.com>
Date: Mon Sep 27 16:20:27 2021

Remove intent query elements from manifest of media2-session

It makes the package visibility filter opted-in by users rather than
automatically by the library.

It partially reverts If2a46bce0cdc78750d08eec66488fe3150610e5b.

Bug: 185314633
Relnote: "The library won't inject the package visibility filter for
`MediaController`, `MediaBrowser`, or `MediaSessionManager` anymore.
Please specify a `<queries>` element in your apps manifest when
targeting API level 30 or higher."
Test: ./media2/media2-session/version-compat-tests/runtest.sh 4 on API 30
Change-Id: If78589b6f645698f859c57d9013b4c7da9183236

M media2/media2-session/src/main/java/androidx/media2/session/MediaSessionManager.java
M media2/media2-session/src/main/AndroidManifest.xml
M media2/media2-session/src/main/java/androidx/media2/session/MediaController.java

https://android-review.googlesource.com/1836877

ap...@google.com <ap...@google.com> #5Sep 29, 2021 02:31AM

Project: platform/frameworks/support
Branch: androidx-main

commit bc89e5d7c7785b0c4ea4842fe73a1e1324b6ea33
Author: Gyumin Sim <gyumin@google.com>
Date: Mon Sep 27 15:41:38 2021

Remove intent query element from manifest of media

It makes the package visibility filter opted-in by users rather than
automatically by the library.

It partially reverts If2a46bce0cdc78750d08eec66488fe3150610e5b.

Bug: 185314633
Relnote: "The library won't inject the package visibility filter for
`MediaBrowserCompat` anymore. Please specify a `<queries>` element
in your apps manifest when targeting API level 30 or higher."
Test: ./media/version-compat-tests/runtest.sh 4 on API 30
Change-Id: I0a964e51887211650279b9bd1efd79ce4c5bb5c2

M media/media/src/main/java/android/support/v4/media/MediaBrowserCompat.java
M media/media/src/main/AndroidManifest.xml

https://android-review.googlesource.com/1836874

gy...@google.com <gy...@google.com> #6Sep 29, 2021 02:51AM

Marked as fixed.

I'm expecting the fix for androidx.media will be released with the version 1.4.3 targeting October 14th.

Issue 185314633