androidx.media library 1.3.0 adds android.media.browse.MediaBrowserService intent query to manifest [185314633]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 14, 2021 04:11PM

Component used: androidx.media

Version used: 1.3.0

Devices/Android versions reproduced on: N/A

After updating androidx.media:media from 1.2.1 to 1.3.0, we see this additional entry in our generated app manifest:

<queries>
    <intent>
        <action android:name="android.media.browse.MediaBrowserService" />
    </intent>
</queries>

We use this library to be able to intercept the media button. We don't need to query activities that support the MediaBrowserService intent.

I know I can remove this by adding the following to my app's manifest, but it would be great if this library didn't automatically add this to the manifest.

<queries>
  <intent tools:node="remove">
    <action android:name="android.media.browse.MediaBrowserService" />
  </intent>
</queries>

Thanks!

Comments

bo...@google.com <bo...@google.com> #2Apr 14, 2021 04:17PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

gy...@google.com <gy...@google.com> #3Apr 15, 2021 01:43AM

Status: Won't Fix (Intended Behavior)

Great! Thanks a lot, I'll look for the live updates soon!

gy...@google.com <gy...@google.com> Sep 27, 2021 06:30AM

Accepted by gy...@google.com.

ap...@google.com <ap...@google.com> #4Sep 28, 2021 08:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit bdcf20ccfe86deb50337184444d7660ad2745916
Author: Gyumin Sim <gyumin@google.com>
Date: Mon Sep 27 16:20:27 2021

Remove intent query elements from manifest of media2-session

It makes the package visibility filter opted-in by users rather than
automatically by the library.

It partially reverts If2a46bce0cdc78750d08eec66488fe3150610e5b.

Bug: 185314633
Relnote: "The library won't inject the package visibility filter for
`MediaController`, `MediaBrowser`, or `MediaSessionManager` anymore.
Please specify a `<queries>` element in your apps manifest when
targeting API level 30 or higher."
Test: ./media2/media2-session/version-compat-tests/runtest.sh 4 on API 30
Change-Id: If78589b6f645698f859c57d9013b4c7da9183236

M media2/media2-session/src/main/java/androidx/media2/session/MediaSessionManager.java
M media2/media2-session/src/main/AndroidManifest.xml
M media2/media2-session/src/main/java/androidx/media2/session/MediaController.java

https://android-review.googlesource.com/1836877

ap...@google.com <ap...@google.com> #5Sep 29, 2021 02:31AM

Project: platform/frameworks/support
Branch: androidx-main

commit bc89e5d7c7785b0c4ea4842fe73a1e1324b6ea33
Author: Gyumin Sim <gyumin@google.com>
Date: Mon Sep 27 15:41:38 2021

Remove intent query element from manifest of media

It makes the package visibility filter opted-in by users rather than
automatically by the library.

It partially reverts If2a46bce0cdc78750d08eec66488fe3150610e5b.

Bug: 185314633
Relnote: "The library won't inject the package visibility filter for
`MediaBrowserCompat` anymore. Please specify a `<queries>` element
in your apps manifest when targeting API level 30 or higher."
Test: ./media/version-compat-tests/runtest.sh 4 on API 30
Change-Id: I0a964e51887211650279b9bd1efd79ce4c5bb5c2

M media/media/src/main/java/android/support/v4/media/MediaBrowserCompat.java
M media/media/src/main/AndroidManifest.xml

https://android-review.googlesource.com/1836874

gy...@google.com <gy...@google.com> #6Sep 29, 2021 02:51AM

Marked as fixed.

I'm expecting the fix for androidx.media will be released with the version 1.4.3 targeting October 14th.

Issue 185314633