Fixed
Status Update
No update yet.
Comments
ni...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
da...@google.com
da...@google.com
da...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Add an API in the database builder to configure if TEMP tables are to be used for tracking.
Expand for full commit details
Add an API in the database builder to configure if TEMP tables are to be used for tracking.
Whether an in-memory / TEMP table is used for invalidation tracking needs to be configured to workaround a behaviour in Samsung devices with Android O, O_MR1 and P where if using the framework bindings, the connection pool is disabled (locked to a single primary connection) when a TEMP table is created in WAL mode.
Bug: 185414040
Bug: 380344913
Test: Executed :room:integration-tests:room-testapp-kotlin:cAT with useTempTable = false.
Relnote: "Add the experimental API RoomDatabase.Builder.setInMemoryTrackingMode() to configure whether Room will use an in-memory table or not for invalidation tracking."
Change-Id: I2a9b2784f3418ece9814e3c077aef512309cdc26
Files:
- M
room/room-runtime/api/current.txt - M
room/room-runtime/api/restricted_current.txt - M
room/room-runtime/src/androidMain/kotlin/androidx/room/DatabaseConfiguration.android.kt - M
room/room-runtime/src/androidMain/kotlin/androidx/room/InvalidationTracker.android.kt - M
room/room-runtime/src/androidMain/kotlin/androidx/room/RoomDatabase.android.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/InvalidationTracker.kt - M
room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/InvalidationTracker.jvmNative.kt
Hash: 3931796610acbeee8e7aef1aec876629f774552c
Date: Tue Dec 03 19:36:01 2024
da...@google.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-runtime:2.7.0-alpha12androidx.room:room-runtime-android:2.7.0-alpha12androidx.room:room-runtime-iosarm64:2.7.0-alpha12androidx.room:room-runtime-iossimulatorarm64:2.7.0-alpha12androidx.room:room-runtime-iosx64:2.7.0-alpha12androidx.room:room-runtime-jvm:2.7.0-alpha12androidx.room:room-runtime-linuxarm64:2.7.0-alpha12androidx.room:room-runtime-linuxx64:2.7.0-alpha12androidx.room:room-runtime-macosarm64:2.7.0-alpha12androidx.room:room-runtime-macosx64:2.7.0-alpha12
Description
Component used: Room Version used: 2.2.6 Devices/Android versions reproduced on: Samsung Galaxy 8(Android 8.0/9.0) Samsung Galaxy 9(Android 8.0/9.0)
InvalidationTrackeruses in memory temp table( "CREATE TEMP TABLE ....") to notify about changes in tables; Declaring temp table for sqlite in WAL mode on some Samsung devices results inSQLiteConnectionPool.mMaxConnectionPoolSizebeing set to 1 (although, It should be at least 2 in WAL mode)So accessing to database in multiple threads cause to lock of threads. See logs:
SQLiteConnectionPool: The connection pool for database '<name of database>' has been unable to grant a connection to thread with flags 0x5 for 30.0010004 seconds. Connections: 0 active, 1 idle, 0 available