Status Update
Comments
jb...@google.com <jb...@google.com> #2
Known issue, we cannot do anything because AGP doesn't provide an API to fetch Kotlin sources (specifically here
[Deleted User] <[Deleted User]> #3
Would you be opposed to failing the build if we see a src/kotlin
directory?
il...@google.com <il...@google.com>
[Deleted User] <[Deleted User]> #4
No, go ahead if you want to add that check.
jb...@google.com <jb...@google.com> #5
Adding to bounty list since this isn't a frequent occurrence.
- Sponsor: alanv
- Tech stack: Gradle build plugin
- Summary: Add check in
AndroidXPluginImpl
that raises an exception if a project is usingsrc/kotlin
for its source sets. The exception should indicate thatsrc/kotlin
is not fully supported by AGP and thatsrc/java
should be used instead.
il...@google.com <il...@google.com>
[Deleted User] <[Deleted User]> #6
I'm seeing one library that's using src/main/kotlin
and seems to generate API files without issue: paging/paging-common
. Aurimas, any idea what might be going on there?
il...@google.com <il...@google.com> #7
That library is
plugins {
id("AndroidXPlugin")
id("kotlin")
}
a non android library and we use a different path for java/kotlin libraries.
Description
Component used: Navigation
Version used: 2.3.5
Devices/Android versions reproduced on: Any
Problem
We have two deep links:
myapp://example.io/messages/{userId}?message={messageId}
myapp://example.io/messages/anonymous?message={messageId}
And the link:
myapp://example.io/messages/anonymous?message=1
The second deep link will not be selected because the first one has two matching arguments. And this link is not an "exact deep link" because it has a query parameter.
Purposed solution
Mark deep links as exact if it does not contain arguments in path. Allow exact deep links to contain query parameters.
If this solution is right, I can create pull request on GitHub.