Check required parameters in deep links query parameters [185527157]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 16, 2021 06:23AM

Component used: Navigation
Version used: 2.3.5
Devices/Android versions reproduced on: Any

Problem

We have deep link: myapp://example.io/messages/{userId}?message={messageId}&source={source}
Where all arguments are required.

And we have a link: myapp://example.io/messages/anonymous?message=1

This link will be caught by the deep link and an app will crash because the required parameter source is missing.

Purposed solution

When checking deep link match, check if query parameters are required.

If this solution is right, I can create pull request on GitHub.

Comments

il...@google.com <il...@google.com> Jun 1, 2021 08:14PM

Assigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Jun 2, 2021 06:39AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

jb...@google.com <jb...@google.com> #3Jun 3, 2021 08:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

il...@google.com <il...@google.com> Jun 15, 2021 08:18PM

Reassigned to sa...@google.com.

[Deleted User] <[Deleted User]> #4Jun 20, 2021 04:26PM

deleted

ca...@gmail.com <ca...@gmail.com> #5Aug 12, 2021 05:44AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

[Deleted User] <[Deleted User]> #6Aug 18, 2021 07:06AM

PR is merged!

jb...@google.com <jb...@google.com> #7Aug 18, 2021 05:32PM

Marked as fixed.

Thank you for the PR!

This has been fixed internally and will be available as part of the Navigation 2.4.0-alpha08 release.

da...@gmail.com <da...@gmail.com> #8Sep 1, 2021 10:18PM

Just a quick note. It seems like NavInflater don't set defaultValue when using android:defaultValue="@null" and thus the check will fail. You will have to add the query argument in your Uri : "http://myuri/stuff?defaultToNullArg={defaultToNullArg}"

br...@gmail.com <br...@gmail.com> #9Sep 3, 2021 01:23PM

I filed an issue RE: #8 ... an @null default value should not be flagged as "required", and should not fail and cause the app to crash.

https://issuetracker.google.com/issues/198689811