Check required parameters in deep links query parameters [185527157]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 16, 2021 06:23AM

Component used: Navigation
Version used: 2.3.5
Devices/Android versions reproduced on: Any

Problem

We have deep link: myapp://example.io/messages/{userId}?message={messageId}&source={source}
Where all arguments are required.

And we have a link: myapp://example.io/messages/anonymous?message=1

This link will be caught by the deep link and an app will crash because the required parameter source is missing.

Purposed solution

When checking deep link match, check if query parameters are required.

If this solution is right, I can create pull request on GitHub.

Comments

il...@google.com <il...@google.com> Jun 1, 2021 08:14PM

Assigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Jun 2, 2021 06:39AM

since these are in public API (:/) we need to do this in 1.2

jb...@google.com <jb...@google.com> #3Jun 3, 2021 08:30PM

since it is already marked as deprecated, we can probably do it by now.

il...@google.com <il...@google.com> Jun 15, 2021 08:18PM

Reassigned to sa...@google.com.

[Deleted User] <[Deleted User]> #4Jun 20, 2021 04:26PM

Opening diff shortly

ca...@gmail.com <ca...@gmail.com> #5Aug 12, 2021 05:44AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

[Deleted User] <[Deleted User]> #6Aug 18, 2021 07:06AM

PR is merged!

jb...@google.com <jb...@google.com> #7Aug 18, 2021 05:32PM

Marked as fixed.

Thank you for the PR!

This has been fixed internally and will be available as part of the Navigation 2.4.0-alpha08 release.

da...@gmail.com <da...@gmail.com> #8Sep 1, 2021 10:18PM

Just a quick note. It seems like NavInflater don't set defaultValue when using android:defaultValue="@null" and thus the check will fail. You will have to add the query argument in your Uri : "http://myuri/stuff?defaultToNullArg={defaultToNullArg}"

br...@gmail.com <br...@gmail.com> #9Sep 3, 2021 01:23PM

I filed an issue RE: #8 ... an @null default value should not be flagged as "required", and should not fail and cause the app to crash.

https://issuetracker.google.com/issues/198689811