Status Update
Comments
il...@google.com <il...@google.com>
[Deleted User] <[Deleted User]> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
jb...@google.com <jb...@google.com> #3
il...@google.com <il...@google.com>
[Deleted User] <[Deleted User]> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ca...@gmail.com <ca...@gmail.com> #5
I think your PR also fixes our problem: we have links like
.../search/
.../search?documentId=123
.../search?folder=123
And each should be redirected to different navigation destinations. Currently they all redirect to one page, and sometimes crash.
jb...@google.com <jb...@google.com> #7
Thank you for the PR!
This has been fixed internally and will be available as part of the Navigation 2.4.0-alpha08
release.
da...@gmail.com <da...@gmail.com> #8
Just a quick note. It seems like NavInflater don't set defaultValue when using android:defaultValue="@null" and thus the check will fail. You will have to add the query argument in your Uri : "
br...@gmail.com <br...@gmail.com> #9
I filed an issue RE: #8 ... an @null
default value should not be flagged as "required", and should not fail and cause the app to crash.
Description
Component used: Navigation
Version used: 2.3.5
Devices/Android versions reproduced on: Any
Problem
We have deep link:
myapp://example.io/messages/{userId}?message={messageId}&source={source}
Where all arguments are required.
And we have a link:
myapp://example.io/messages/anonymous?message=1
This link will be caught by the deep link and an app will crash because the required parameter
source
is missing.Purposed solution
When checking deep link match, check if query parameters are required.
If this solution is right, I can create pull request on GitHub.