Check required parameters in deep links query parameters [185527157]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 16, 2021 06:23AM

Component used: Navigation
Version used: 2.3.5
Devices/Android versions reproduced on: Any

Problem

We have deep link: myapp://example.io/messages/{userId}?message={messageId}&source={source}
Where all arguments are required.

And we have a link: myapp://example.io/messages/anonymous?message=1

This link will be caught by the deep link and an app will crash because the required parameter source is missing.

Purposed solution

When checking deep link match, check if query parameters are required.

If this solution is right, I can create pull request on GitHub.

Comments

il...@google.com <il...@google.com> Jun 1, 2021 08:14PM

Assigned to jb...@google.com.

[Deleted User] <[Deleted User]> #2Jun 2, 2021 06:39AM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

jb...@google.com <jb...@google.com> #3Jun 3, 2021 08:30PM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

il...@google.com <il...@google.com> Jun 15, 2021 08:18PM

Reassigned to sa...@google.com.

[Deleted User] <[Deleted User]> #4Jun 20, 2021 04:26PM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

ca...@gmail.com <ca...@gmail.com> #5Aug 12, 2021 05:44AM

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

[Deleted User] <[Deleted User]> #6Aug 18, 2021 07:06AM

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

jb...@google.com <jb...@google.com> #7Aug 18, 2021 05:32PM

Marked as fixed.

Added a patch for androidx-master-dev that demos a horizontal ViewPager2 inside a vertical RecyclerView.

Verified that it works correctly on a:
- Nexus 4 emulator with API 17
- Nexus 5X emulator with API 28
- Pixel 2 device with API 29

To reproduce:
- Check out the Android Jetpack source (at commit 256899f482ff85cddfb050f37550be7b5ec927ef) (see steps in [1])
- Apply the patch (`git apply 0001-Add-sample-where-a-horizontal-ViewPager2-is-nested-i.patch`)
- Build and install viewpager2's integration-tests app: `./gradlew viewpager2:integration-tests:testapp:installDebug`
- Run it

Closing the issue for now, but please reopen if you have a minimal reproduction app

[1]

https://android.googlesource.com/platform/frameworks/support/+/256899f482ff85cddfb050f37550be7b5ec927ef

da...@gmail.com <da...@gmail.com> #8Sep 1, 2021 10:18PM

Re-opening as requested by a few users. Narrowed down the focus to nested scrolling elements with the same scroll direction.

br...@gmail.com <br...@gmail.com> #9Sep 3, 2021 01:23PM

Any progress on this? (only talking about the "same scroll direction" issue)

I searched a lot for workarounds on Google and SO, but it seems no one really found a suitable solution yet.
The thing is that all other VerticalViewPagers out there have other problems that are similarly annoying. Most of them revolve around touch issues like "What's a click and what's a swipe" or "what's the fling threshold to snap to the next page".

So if someone knows of a working sample of VerticalViewPagers, I'd be happy to see a link :)