Android gradle plugin 4.2.0-rc01 obfuscates res folder even though -dontobfuscate is enabled [185532483]

In Progress

Bug

Status Update

No update yet.

Description

my...@gmail.com

created issue #1

Apr 16, 2021 09:29PM

To reproduce, grab this: https://github.com/Mygod/VPNHotspot/commit/c4d44b97509af9fea9c1d38061629f8fedb2c22d

Build apk in Android Studio and put in apk analyzer. Observe that classes.dex are not obfuscated (all classes keep their old names) but things in res folders are renamed.

Downgrading to 4.1.3 from 4.2.0-rc01 fixes this.

Comments

ri...@google.com <ri...@google.com> #2Apr 19, 2021 05:41AM

To enable us to triage this correctly does:
minifyEnabled false
fix the issue, if not, this is not a R8 problem
Also, do you use resource shrinking? (i.e., do you have shrinkResources true)

my...@gmail.com <my...@gmail.com> #3Apr 19, 2021 06:20AM

As you can see in the source code, both of them are enabled. I'll try turning it off and update you.

sg...@google.com <sg...@google.com> Apr 19, 2021 11:10AM

Reassigned to ri...@google.com.

my...@gmail.com <my...@gmail.com> #4Apr 19, 2021 04:49PM

Turning off both minimizing options still yields the same result (renamed res folders). I guess this is not a R8 issue. Could you help me transfer this issue then? :)

ri...@google.com <ri...@google.com> #5Apr 20, 2021 07:34AM

Reassigned to ga...@google.com.

Ivan: do you know why we would rename those files?
Turning off resource shrinking and r8 still have these files be renamed like:
-rw---- 0.0 fat 1732 b- defN 81-Jan-01 01:01 res/--.xml
-rw---- 0.0 fat 472 b- defN 81-Jan-01 01:01 res/-A.xml
-rw---- 0.0 fat 724 b- defN 81-Jan-01 01:01 res/-A1.xml
-rw---- 0.0 fat 1396 b- defN 81-Jan-01 01:01 res/-Y.xml
-rw---- 0.0 fat 528 b- defN 81-Jan-01 01:01 res/-c.xml
-rw---- 0.0 fat 532 b- defN 81-Jan-01 01:01 res/-o.xml
-rw---- 0.0 fat 1100 b- defN 81-Jan-01 01:01 res/-u.xml
-rw---- 0.0 fat 404 b- stor 81-Jan-01 01:01 res/06.png
-rw---- 0.0 fat 212 b- stor 81-Jan-01 01:01 res/09.9.png
-rw---- 0.0 fat 207 b- stor 81-Jan-01 01:01 res/0H.9.png

ga...@google.com <ga...@google.com> #6Apr 20, 2021 08:04AM

Does adding android.enableResourceOptimizations=false to gradle.properties fix the issue for you? AGP started optimizing Android resources for release variants by default in order to reduce APK size.

my...@gmail.com <my...@gmail.com> #7Apr 20, 2021 04:24PM

Indeed that fixes this, even if both minifying options are enabled in gradle files. However, this also seems to turn off other optimizations like converting to webm files.

The main reason I would like to disable renaming is to use APK size analyzer and diff reports. Is there any way to make it so that only renaming is disabled, for example, respecting -dontobfuscate setting in Proguard configuration somehow?

ga...@google.com <ga...@google.com> #8Apr 20, 2021 05:11PM

Reassigned to lu...@google.com.

We do plan to add more options for configuring Android resource optimizations. Luke, can you please link to the relevant issue?

lu...@google.com <lu...@google.com> #9Apr 21, 2021 08:39AM

Yes, we're planning to add dsl options in the future to provide a way to configure the exact parameters of resource optimisations. There is currently, b/155745910 for letting build authors control the collapse-resource-names optimisation parameter, however it seems that after b/184666005 we need to add support for more options.

my...@gmail.com <my...@gmail.com> #10May 6, 2021 11:06PM

Thanks! Is there anywhere public where I can track when this new parameter is released?

cx...@qq.com <cx...@qq.com> #11Dec 22, 2021 10:01AM

mark

lu...@google.com <lu...@google.com> Jan 20, 2022 01:45PM

Accepted by lu...@google.com.

ja...@gmail.com <ja...@gmail.com> #12Jan 27, 2022 12:10AM

Hi, Is there any update ?

lu...@google.com <lu...@google.com> #13Jan 27, 2022 09:46AM

Active development on adding buildTypes options based on the AAPT2 Optimize suboperations has started in the last week. I'll keep you posted when they make it in to an alpha release of AGP.

ja...@gmail.com <ja...@gmail.com> #14Jun 21, 2023 11:10PM

Can I know the option name?