Safe Args Generated Classes failing Jetpack API Lint check [185843837]

Fixed

Bug

Status Update

No update yet.

Description

ds...@google.com

created issue #1

Apr 20, 2021 01:02AM

Component used: Navigation, Safe Args plugin

Version used: 2.3.4

Hi!

I'm working on creating a debug view for AppSearch as a Jetpack library. I'm using Navigation component for managing switching between fragments. I'm using the Safe Args plugin for passing in arguments to a destination fragment. However, the classes the Safe Args plugin generates in the build tree are causing the Jetpack API lint check to fail:

> Task :appsearch:appsearch-debug-view:generateApi

../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:119: error: Builder must be final: androidx.appsearch.debugview.view.DocumentFragmentArgs.Builder [StaticFinalBuilder]
../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:165: error: Getter should be on the built object, not the builder: method androidx.appsearch.debugview.view.DocumentFragmentArgs.Builder.getDocumentUri() [GetterOnBuilder]
../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:171: error: Getter should be on the built object, not the builder: method androidx.appsearch.debugview.view.DocumentFragmentArgs.Builder.getDocumentNamespace() [GetterOnBuilder]
../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:123: error: Missing nullability o    Your change has API lint issues. Fix the code according to the messages above.

    If a check is broken, suppress it in code in Kotlin with @Suppress("id")/@get:Suppress("id")
    and in Java with @SuppressWarnings("id") and file bug to
    https://issuetracker.google.com/issues/new?component=739152&template=1344623

    If you are doing a refactoring or suppression above does not work, use ./gradlew updateApiLintBaseline

The class generating these errors is attached. I would appreciate it if the Lint issues could be resolved so I can continue using Safe Args!

DocumentFragmentArgs.java

6 KB

View

Download

Comments

il...@google.com <il...@google.com> #2Apr 20, 2021 04:53PM

Assigned to jb...@google.com.

Hey Doris, any ideas on where this random animation could be coming from?

ap...@google.com <ap...@google.com> #3Aug 18, 2021 08:07PM

Re comment #1,

I tried the repro project locally. I was not able to reproduce in the the tip of tree compose code base, after dozens of attempts. It's possible the issue has been fixed recently.

Could you try the latest androidx snapshot here: https://androidx.dev/snapshots/builds and let us know if you still see the issue?

jb...@google.com <jb...@google.com> #4Aug 18, 2021 08:11PM

Marked as fixed.

Hi! Thank you for checking into it and giving it a try.

Unfortunately, the issue is still reproducible with snapshot 12123985, 2.8.0-SNAPSHOT for navigation, and 1.8.0-SNAPSHOT for compose.

I've pushed an update containing SNAPSHOT dependencies and automated reproduction attempts: https://github.com/smelfungus/NavHostAnimationIssue

Now, it's sufficient to launch the application and wait.

Here's a new video: https://drive.google.com/file/d/1q3C3ErIzPbTdfLsZH85KgPGNqmL-h1MN/view?usp=sharing

Issue 185843837

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Apr 20, 2021 04:53PM

ap...@google.com <ap...@google.com> #3Aug 18, 2021 08:07PM

jb...@google.com <jb...@google.com> #4Aug 18, 2021 08:11PM

Add comment

Issue metadata