Safe Args Generated Classes failing Jetpack API Lint check [185843837]

Fixed

Bug

Status Update

No update yet.

Description

ds...@google.com

created issue #1

Apr 20, 2021 01:02AM

Component used: Navigation, Safe Args plugin

Version used: 2.3.4

Hi!

I'm working on creating a debug view for AppSearch as a Jetpack library. I'm using Navigation component for managing switching between fragments. I'm using the Safe Args plugin for passing in arguments to a destination fragment. However, the classes the Safe Args plugin generates in the build tree are causing the Jetpack API lint check to fail:

> Task :appsearch:appsearch-debug-view:generateApi

../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:119: error: Builder must be final: androidx.appsearch.debugview.view.DocumentFragmentArgs.Builder [StaticFinalBuilder]
../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:165: error: Getter should be on the built object, not the builder: method androidx.appsearch.debugview.view.DocumentFragmentArgs.Builder.getDocumentUri() [GetterOnBuilder]
../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:171: error: Getter should be on the built object, not the builder: method androidx.appsearch.debugview.view.DocumentFragmentArgs.Builder.getDocumentNamespace() [GetterOnBuilder]
../../../../out/androidx/appsearch/appsearch-debug-view/build/generated/source/navigation-args/release/androidx/appsearch/debugview/view/DocumentFragmentArgs.java:123: error: Missing nullability o    Your change has API lint issues. Fix the code according to the messages above.

    If a check is broken, suppress it in code in Kotlin with @Suppress("id")/@get:Suppress("id")
    and in Java with @SuppressWarnings("id") and file bug to
    https://issuetracker.google.com/issues/new?component=739152&template=1344623

    If you are doing a refactoring or suppression above does not work, use ./gradlew updateApiLintBaseline

The class generating these errors is attached. I would appreciate it if the Lint issues could be resolved so I can continue using Safe Args!

DocumentFragmentArgs.java

6 KB

View

Download

Comments

il...@google.com <il...@google.com> #2Apr 20, 2021 04:53PM

Assigned to jb...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Aug 18, 2021 08:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0cf2de39de68f680b2912a64ebf72c164b87aabc
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Aug 18 12:27:52 2021

Fix safe args builder lint warnings

The SafeArgs java generator currently has lint warnings for the Builder
not being final, missing nullability annotation, and getter on builder
errors.

The change makes the appropriate changes to prevent those warnings.

RelNote: "The SafeArgs java generator should no longer cause lint
warnings when generating Args classes."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-generator:test
Bug: 185843837

Change-Id: I1a6661b10b8e380aaa9fcfd1fc710c35b047bd6d

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragment$InnerFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/SanitizedMainFragmentArgs.java

https://android-review.googlesource.com/1800570

jb...@google.com <jb...@google.com> #4Aug 18, 2021 08:11PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.4.0-alpha08 release.

Issue 185843837

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Apr 20, 2021 04:53PM

ap...@google.com <ap...@google.com> #3Aug 18, 2021 08:07PM

jb...@google.com <jb...@google.com> #4Aug 18, 2021 08:11PM

Add comment

Issue metadata