Fixed
Status Update
No update yet.
Comments
[Deleted User] <[Deleted User]>
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
il...@google.com
jb...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ae19215aa71372218770972d89c1b65f463a8291
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Apr 28 15:57:15 2021
Fix window insets dispatch for API 29
Right now we call ViewCompat.onApplyWindowInsets from
FragmentContainerView's dispatchApplyWindowInsets method. When combined
with fitSystemWindows on API 29, fitSystemWindows kicks off its own
dispatch cycle, which makes us dispatch indefinitely.
We should override onApplyWindowInsets to simple return the given insets
so we properly stop dispatching insets.
RelNote: "When using `FragmentContainerView` on API 29, insets will no
longer dispatch indefinitely."
Test: FragmentContainerViewTest
Bug: 186012452
Change-Id: I1bb780dffcbbcb6a78fbfb74d288a3c0620a3a40
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
https://android-review.googlesource.com/1690232
Branch: androidx-main
commit ae19215aa71372218770972d89c1b65f463a8291
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Apr 28 15:57:15 2021
Fix window insets dispatch for API 29
Right now we call ViewCompat.onApplyWindowInsets from
FragmentContainerView's dispatchApplyWindowInsets method. When combined
with fitSystemWindows on API 29, fitSystemWindows kicks off its own
dispatch cycle, which makes us dispatch indefinitely.
We should override onApplyWindowInsets to simple return the given insets
so we properly stop dispatching insets.
RelNote: "When using `FragmentContainerView` on API 29, insets will no
longer dispatch indefinitely."
Test: FragmentContainerViewTest
Bug: 186012452
Change-Id: I1bb780dffcbbcb6a78fbfb74d288a3c0620a3a40
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
jb...@google.com
This has been fixed internally and will be part of the Fragment 1.3.4 release.
Description
Version used: androidx.fragment:fragment-ktx:1.3.3
Devices/Android versions reproduced on: Google Pixel API 29
I've noticed that reveal animation on view outside fragment container not working on 1.3.3, when fragment container contains bottom nav (see videos).
It seems like an inset dispatching problem, cause logs shows a lot of useless inset events on reveal target view (see screenshots).
Test project also attached.