Fixed
Status Update
No update yet.
Comments
[Deleted User] <[Deleted User]>
Project: platform/frameworks/support
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/141 .
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
https://android-review.googlesource.com/1649748
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request from
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
il...@google.com
jb...@google.com
There was something done with window insets on API 29 where they work differently than every other API. I am guessing if you did this on another API level everything works fine.
Adding Chris, Adrian, Jorim, and Paul to see if they have any ideas on how
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ae19215aa71372218770972d89c1b65f463a8291
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Apr 28 15:57:15 2021
Fix window insets dispatch for API 29
Right now we call ViewCompat.onApplyWindowInsets from
FragmentContainerView's dispatchApplyWindowInsets method. When combined
with fitSystemWindows on API 29, fitSystemWindows kicks off its own
dispatch cycle, which makes us dispatch indefinitely.
We should override onApplyWindowInsets to simple return the given insets
so we properly stop dispatching insets.
RelNote: "When using `FragmentContainerView` on API 29, insets will no
longer dispatch indefinitely."
Test: FragmentContainerViewTest
Bug: 186012452
Change-Id: I1bb780dffcbbcb6a78fbfb74d288a3c0620a3a40
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
https://android-review.googlesource.com/1690232
Branch: androidx-main
commit ae19215aa71372218770972d89c1b65f463a8291
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Apr 28 15:57:15 2021
Fix window insets dispatch for API 29
Right now we call ViewCompat.onApplyWindowInsets from
FragmentContainerView's dispatchApplyWindowInsets method. When combined
with fitSystemWindows on API 29, fitSystemWindows kicks off its own
dispatch cycle, which makes us dispatch indefinitely.
We should override onApplyWindowInsets to simple return the given insets
so we properly stop dispatching insets.
RelNote: "When using `FragmentContainerView` on API 29, insets will no
longer dispatch indefinitely."
Test: FragmentContainerViewTest
Bug: 186012452
Change-Id: I1bb780dffcbbcb6a78fbfb74d288a3c0620a3a40
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
jb...@google.com
This has been fixed internally and will be part of the Fragment 1.3.4 release.
Description
Version used: androidx.fragment:fragment-ktx:1.3.3
Devices/Android versions reproduced on: Google Pixel API 29
I've noticed that reveal animation on view outside fragment container not working on 1.3.3, when fragment container contains bottom nav (see videos).
It seems like an inset dispatching problem, cause logs shows a lot of useless inset events on reveal target view (see screenshots).
Test project also attached.