ViewModel compose extension failed to work with Fragment 1.3.3 [186097368]

Fixed

Bug

Status Update

No update yet.

Description

b9...@gmail.com

created issue #1

Apr 22, 2021 06:02PM

FragmentViewLifecycleOwner implement ViewModelStoreOwner in Fragment 1.3.3

    public ViewModelProvider(@NonNull ViewModelStoreOwner owner) {
        this(owner.getViewModelStore(), owner instanceof HasDefaultViewModelProviderFactory
                ? ((HasDefaultViewModelProviderFactory) owner).getDefaultViewModelProviderFactory()
                : NewInstanceFactory.getInstance());
    }

ViewModel compose extension use this constructor by default.
Fragment set ViewTreeViewModelStoreOwner to FragmentViewLifecycleOwner in 1.3.3, which means 1. will inject FragmentViewLifecycleOwner.
FragmentViewLifecycleOwner didn't implement HasDefaultViewModelProviderFactory, so that NewInstanceFactory will be used to create ViewModel. Which means DI framework like Hilt will failed, the ViewModel constructor can't have any parameter.

Comments

b9...@gmail.com <b9...@gmail.com> #2Apr 22, 2021 07:18PM

Please include a sample project that reproduces your issue.

il...@google.com <il...@google.com> #3Apr 22, 2021 07:24PM

Assigned to jb...@google.com.

Here is the sample project.

Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;

With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.

Please suggest some workarounds or how to fix this issue?

b9...@gmail.com <b9...@gmail.com> #4Apr 22, 2021 08:11PM

Hello, have you checked sample project? I hope it will help find the issue.

il...@google.com <il...@google.com> #5Apr 22, 2021 08:28PM

@3
I've described a weird workaround that I got, here:

https://issuetracker.google.com/issues/244854449#comment3
Sample:

https://issuetracker.google.com/issues/244854449#comment4

It probably has bugs of its own that I didn't think of.
Google please fix this.

jb...@google.com <jb...@google.com> May 4, 2021 04:54PM

Reassigned to sa...@google.com.

il...@google.com <il...@google.com> #6May 5, 2021 04:17PM

Hello, any update please?

ap...@google.com <ap...@google.com> #7May 10, 2021 11:08PM

Hello I raised similar issue with this ticket https://issuetracker.google.com/issues/249247706

This makes the SearchView unusable/broken when fragments are changed (i.e base on searchView input query)

What can we do to fix this problem? What is the progress of work on solving this problem?

il...@google.com <il...@google.com> #8May 11, 2021 12:03AM

Marked as fixed.

@7 Check @5 for a workaround.