IssueTracker

Please note: This component is for the CameraX API used in Jetpack. Please DO NOT file Pixel Camera issues here.

Please describe your issue and include details such as the version of CameraX you are using and any relevant logs related to your issue.

// If at all possible, capture an Android logcat (https://developer.android.com/studio/command-line/logcat) when you're experiencing the issue, preferably while the camera is still active.

CAMERAX VERSION (ex - 1.0.0-alpha07)

'androidx.camera:camera-view:1.0.0-alpha24'

CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version)

CameraXbasic (https://github.com/android/camera-samples/tree/master/CameraXBasic) Commit: 2690075bca44d51e4e37df07273d1f8d7fe9846f [2690075] (2021-04-01 10:07:26)

• patch.diff (attachment)

ANDROID OS BUILD NUMBER: (Settings > About > Build number)

R16NW.A320FLXXS9CTL4

DEVICE NAME: (Nexus 5X, Samsung S6, etc)

Samsung Galaxy A3 2017

DESCRIPTION:

I believe this issue is related to https://issuetracker.google.com/issues/180121821. There were two fixes applied according the changelog in 1.0.0-alpha23 and 1.0.0-alpha24 for devices: Samsung Galaxy A3 2017 Samsung J5 Prime

These fixes solved the issue in default CameraX configuration, but the issue still occurs when we call this method:

ImageAnalyzer.Builder.setTargetResolution()

LIST ANY EXPERIMENTAL FEATURES: (As an example - @ExperimentalCamera2Interop)

STEPS TO REPRODUCE:

1. Checkout https://github.com/android/camera-samples/tree/master/CameraXBasic (Commit: 2690075bca44d51e4e37df07273d1f8d7fe9846f)
2. Apply patch.diff

OR:

1. Use the basic code from https://developer.android.com/training/camerax/analyze (Preview and ImageAnalyzer guide)
2. Call the ImageAnalyzer.Builder as follows:

ImageAnalysis.Builder().setTargetResolution(Size(1080, 1920)).build();

OBSERVED RESULTS: The preview is stretched. See: CameraX_Samsung_Galaxy_A3_2017.png

EXPECTED RESULTS: The preview should be "normal". See: CameraX_Google_Pixel_2.png

REPRODUCIBILITY: (5 of 5, 1 of 100, etc)

100%

ADDITIONAL INFORMATION:

Workaround to solve the issue:

previewView.setScaleX(0.75f);

OR:

previewView.setScaleY(0.75f);

CODE FRAGMENTS (this will help us troubleshoot your issues):

See my workaround based on the existing fix in 'androidx.camera:camera-view:1.0.0-alpha24':

/**
 * This is a temporary workaround for known preview issue.
 * Affected devices:
 * Samsung Galaxy A3 2017, back facing camera
 * Samsung J5 Prime, back facing camera
 * <p>
 * The code is inspirated by this fix:
 * https://android-review.googlesource.com/c/platform/frameworks/support/+/1647928/11/camera/camera-view/src/main/java/androidx/camera/view/internal/compat/quirk/PreviewOneThirdWiderQuirk.java
 */
public class PreviewOneThirdWiderQuirk {

    private static final String SAMSUNG_A3_2017 = "A3Y17LTE";
    private static final String SAMSUNG_J5_PRIME = "ON5XELTE";

    public void solve(PreviewView previewView, int targetRotation) {
        if (isApplicable()) {
            scalePreviewView(previewView, targetRotation);
        }
    }

    private boolean isApplicable() {
        boolean isSamsungJ5PrimeAndApi26 = SAMSUNG_J5_PRIME.equals(Build.DEVICE.toUpperCase()) && Build.VERSION.SDK_INT >= 26;
        boolean isSamsungA3 = SAMSUNG_A3_2017.equals(Build.DEVICE.toUpperCase());
        return isSamsungJ5PrimeAndApi26 || isSamsungA3;
    }

    private void scalePreviewView(PreviewView previewView, int targetRotation) {
        switch (targetRotation) {
            case Surface.ROTATION_90:
            case Surface.ROTATION_270:
                previewView.setScaleX(0.75f);
                break;
            default:
                previewView.setScaleY(0.75f);
        }
    }
}