IssueTracker

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link:      https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.8.0-alpha06
• androidx.compose.foundation:foundation-android:1.8.0-alpha06
• androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
• androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Thanks for the reproduction - I can reproduce too.

I think the problem is that we wait for an up signal to emit a PressInteraction.Release / PressInteraction.Cancel event, and hence cancel the ripple (tryAwaitRelease). To do this we wait for an up event:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/TapGestureDetector.kt;l=132

And because we create a Popup during long press, something changes in dispatch - events seem to be coming through, so I think there is something strange happening with awaitPointerEvent - from some brief logging it looks like we never resume after:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/TapGestureDetector.kt;l=316

So maybe we aren't correctly dispatching the events after the popup has launched, in the correct pass? Matvei, can you take a look?

Note: since we migrated to use RippleDrawable I noticed a small issue that means this doesn't reproduce cleanly, since when window focus changes the RippleDrawable has its ripple cleared. You can reproduce on ToT by doing:

CompositionLocalProvider(LocalRippleNativeRendering provides false) {
}

around the ripple - but the actual root bug here is we are not emitting the PressInteraction release / cancel events.

Thanks for a lot of useful info Louis. Assigning to George to take a look at the popup overlap situation, since I believe we faced the similar ones in the past. Also cc-ing Andrey how had dealt with it as well.

Interactive Preview is also affected by that, and the ripple gets stuck sometimes when users interact with some buttons. See issue 188112048.

Re: comment #6

That bug appears to be a separate issue with Interactive Preview - this bug only occurs when a long press opens a new window.

I'm sorry, I haven't been able to get to this bug with all the other things on my plate. If someone else wants to take it, please do.

Ok, finally managed to find the root problem - we don't use rememberUpdatedState() to remember the long click / double click lambdas, so if a long click triggers a recomposition, and those lambdas aren't explicitly memoized / have unstable types that cannot be memoized automatically, new lambda instances will be passed to combinedClickable during recomposition. This means that the keys provided to Modifier.pointerInput change, so we cancel the old coroutine, and we never finish waiting for the up event, and awaitPointerEvent never returns because things are cancelled / no longer being dispatched here.