Ripple gets "stuck" after a long press [186223077]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 23, 2021 08:56PM

Jetpack Compose release version: 1.0.0-beta05

I'm using a modifier like this:

Modifier.combinedClickable(interactionSource, indication, onClick = {}, onLongClick = {
    ...
})

When the long click listener is called I show a popup dialog which causes the ripple to be stuck in the pressed state until I touch the item again.

Comments

so...@google.com <so...@google.com> Apr 26, 2021 11:08AM

Assigned to lp...@google.com.

lp...@google.com <lp...@google.com> #2Apr 29, 2021 03:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

[Deleted User] <[Deleted User]> #3May 3, 2021 05:48PM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

lp...@google.com <lp...@google.com> May 3, 2021 09:27PM

Reassigned to ma...@google.com.

lp...@google.com <lp...@google.com> #4May 3, 2021 10:39PM

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

ma...@google.com <ma...@google.com> #5May 5, 2021 12:46PM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

am...@google.com <am...@google.com> #6May 14, 2021 12:49PM

Bugjuggler: wait until 2022-03-23

lp...@google.com <lp...@google.com> #7May 14, 2021 12:56PM

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

mo...@google.com <mo...@google.com> #8May 14, 2021 04:03PM

Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?

lp...@google.com <lp...@google.com> #9May 20, 2021 09:50PM

Reassigned to lp...@google.com.

Abandon. The owning team had no plans to release a replacement library.

ap...@google.com <ap...@google.com> #10May 21, 2021 03:52PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 9653864b3c491ed7371ef841bdd292160cbf244e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri May 21 00:55:12 2021

Fixes ripples / indication sometimes getting stuck on a long click

If a long click causes a recomposition and causes the instance of the long click lambda to change, this would cause us to cancel and restart the pointer input scope in Modifier.pointerInput(). This means that we would miss the corresponding up event for that long click, causing no PressInteraction.Release to be emitted, and hence causing ripples / other indication to get 'stuck'.

Now we only cancel and restart this scope if we change from having a long click lambda to not having one (null), and in which case we will now correctly emit PressInteraction.Cancel to clean up any existing long clicks if needed.

Fixes:

b/186223077

Test: ClickableTest
Relnote: "Fixed an issue where ripples / other indication would sometimes get stuck on a long click when using Modifier.combinedClickable"
Change-Id: I2298ce564e3940875c3f3525255424da25dc9414

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt

https://android-review.googlesource.com/1714106