LazyList clips children [186318448]

Fixed

Bug

Status Update

No update yet.

Description

wo...@gmail.com

created issue #1

Apr 26, 2021 03:49PM

I have a LazyRow of Cards.

Now LazyRow creates as a LazyList which creates a SubcomposeLayout which has `clipToBounds() in it's modifiers set.

This leads to LazyRow clipping the shadows of cards. As a workaround I can create enough content padding. This is however a suboptimal solution because that makes it harder to position other elements in relation to that LazyRow composable as it's bottom / top now do not start at the bottom / top of the cards.

It would be great if you could find a way such that LazyRow / LazyColumn would not clip it's children.
Tested on compose beta 5.

Comments

pa...@google.com <pa...@google.com> Apr 26, 2021 04:14PM

Assigned to an...@google.com.

wo...@gmail.com <wo...@gmail.com> #2Apr 26, 2021 04:23PM

I hit this exact stacktrace too. I have a pretty simple app with the only complex screen being a lazygrid layout. not sure what the root cause here could be.

lo...@gmail.com <lo...@gmail.com> #3Apr 26, 2021 05:45PM

As you can see it's been a long time and they do not even answer.

The workaround that is still needed is simple. Since this is a relatively rare issue and not a single user ever contacted about that issue before or after the workaround I guess it's good enough for now.

    @SuppressLint("RestrictedApi")
    override fun dispatchKeyEvent(event: KeyEvent): Boolean {
        return runCatching { super.dispatchKeyEvent(event) }.getOrDefault(false)
    }

ap...@google.com <ap...@google.com> #4May 25, 2021 02:07PM

Marked as fixed.

We recently landed significant changes to the affected code paths. The changes have not been released yet. Can we ask you to either wait for the next alpha release or try one of the latest snapshots?

Thanks!

wo...@gmail.com <wo...@gmail.com> #5May 25, 2021 02:52PM

I've lived 80% of the time on snapshot builds for that app due to all the reports and fixes leading to other reports so not a problem.

Can you point me to the corresponding CLs so I can look at them before removing the workaround for my next release?

[Deleted User] <[Deleted User]> #6Nov 7, 2022 01:19PM

The changes I'm referring to were added in aosp/3032487. Since we don't have a reproducer, this change fixing the issue an an educated guess - we'd be very happy about any reproduction case for the issue.

an...@google.com <an...@google.com> #7Nov 7, 2022 01:23PM

I'd love to have a repro too, it's easier, but as quite a few compose crashes, the stack traces does not give any clue about where in the app it can happen so without the users contacting me with a repro there's not much I can do.

That CL is quite a major change so effectively hard to know if it can fix this.

Let's trust it will.

I'll remove the workaround for next release and we'll see. It's rare enough to be allowed for a short period in prod.