[ML Kit] entity-extraction (latest android lib) is using an old okhttp-urlconnection:3.12.1 [186560102]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 28, 2021 12:17AM

### ENVIRONMENT ###
- Phone make and model: Samsung, Xiaomi, Nokia - any
- OS version: verified on OS 8.0 and 8.1
- ML Kit APIs and versions: 16.0.0-beta1

### STEPS ###
1. use EntityExtraction.getClient(options).downloadModelIfNeeded()

### EXPECTED ###
no crash

### ACTUAL ###
`okhttp3.internal.huc.OkHttpURLConnection` is referenced by `okhttp-urlconnection:3.12.1` within `com.google.mlkit:entity-extraction` but since versions > 3.13.1 of OkHttp removed this class, it crashes

### ADDITIONAL INFORMATION ###
okhttp3.internal.huc.OkHttpURLConnection.d(): [0x95] cannot access instance field q1.b0 p1.l0.n.e.b from object of type Unresolved Reference: p1.l0.n.f (declaration of 'okhttp3.internal.huc.OkHttpURLConnection' appears in /data/app/...==/base.apk:classes3.dex)

Comments

[Deleted User] <[Deleted User]> #2Apr 28, 2021 12:21AM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

[Deleted User] <[Deleted User]> #3Apr 28, 2021 02:53PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

so...@google.com <so...@google.com> #4Apr 28, 2021 04:15PM

Assigned to Deleted User.

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

[Deleted User] <[Deleted User]> #5Apr 28, 2021 04:41PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

so...@google.com <so...@google.com> Apr 30, 2021 05:42PM

Reassigned to ja...@google.com.

ja...@google.com <ja...@google.com> #6May 3, 2021 05:23PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

ja...@google.com <ja...@google.com> #7Jul 30, 2021 04:57PM

Marked as fixed.

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!