[ML Kit] entity-extraction (latest android lib) is using an old okhttp-urlconnection:3.12.1 [186560102]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 28, 2021 12:17AM

### ENVIRONMENT ###
- Phone make and model: Samsung, Xiaomi, Nokia - any
- OS version: verified on OS 8.0 and 8.1
- ML Kit APIs and versions: 16.0.0-beta1

### STEPS ###
1. use EntityExtraction.getClient(options).downloadModelIfNeeded()

### EXPECTED ###
no crash

### ACTUAL ###
`okhttp3.internal.huc.OkHttpURLConnection` is referenced by `okhttp-urlconnection:3.12.1` within `com.google.mlkit:entity-extraction` but since versions > 3.13.1 of OkHttp removed this class, it crashes

### ADDITIONAL INFORMATION ###
okhttp3.internal.huc.OkHttpURLConnection.d(): [0x95] cannot access instance field q1.b0 p1.l0.n.e.b from object of type Unresolved Reference: p1.l0.n.f (declaration of 'okhttp3.internal.huc.OkHttpURLConnection' appears in /data/app/...==/base.apk:classes3.dex)

Comments

[Deleted User] <[Deleted User]> #2Apr 28, 2021 12:21AM

A link to another sample project demonstrating that the leak only happens when using: LocationServices.FusedLocationApi.requestLocationUpdates but does not happen using a deprecated method: googleMap.setOnMyLocationChangeListener.

https://github.com/fernandospr/android-maps-userlocation

[Deleted User] <[Deleted User]> #3Apr 28, 2021 02:53PM

Hello, I'm also experiencing the memory leak in my activity responsible for the location service.

The implementation of my project is not different from the example project attached by fernando.

so...@google.com <so...@google.com> #4Apr 28, 2021 04:15PM

Assigned to Deleted User.

FYI this memory leak also seems to exist when using the new FusedLocationProviderClient. I took Fernano's sample from

comment #2

and hacked it up to use the FusedLocationProviderClient and was still able to observe the leak upon exiting the activity.

[Deleted User] <[Deleted User]> #5Apr 28, 2021 04:41PM

Leak still present in 2019 on latest play-services-location 16.0.0. 3+ years since first reported via linked Github issue, no fix or hint of acknowledgment. Clown college grade software engineering.

so...@google.com <so...@google.com> Apr 30, 2021 05:42PM

Reassigned to ja...@google.com.

ja...@google.com <ja...@google.com> #6May 3, 2021 05:23PM

I am also still experiencing this!

ja...@google.com <ja...@google.com> #7Jul 30, 2021 04:57PM

Marked as fixed.

Still present in 'com.google.android.gms:play-services-location:17.0.0'

As an alternative I am using FusedLocationProviderClient with PendingIntent:

IntentFilter intentFilter = new IntentFilter(ACTION_LOCATION);
registerReceiver(locationReceiver, intentFilter);
mFusedLocationClient.requestLocationUpdates(mLocationRequest, locationPendingIntent);
and
unregisterReceiver(locationReceiver);
mFusedLocationClient.removeLocationUpdates(locationPendingIntent)

Here is forked LocationUpdates repo with LeakCanary installed and an option to switch between LocationCallback and PendingIntent. LeakCanary not reporting anything when using PendingIntent.

https://github.com/dejandobnikar/location-samples/tree/master/LocationUpdates