Status Update
No update yet.
Comments
ma...@google.com
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.
jo...@jossiwolf.de
co...@protonmail.com
In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
ma...@google.com
I don't know how I missed this.
Matvei, would you accept a contribution for this?
Yes, contributions are very welcome, Jossi :)
Thanks for your usecase, coltonidle!
ap...@google.com
Branch: androidx-main
commit 047c2efe097c08370b57a4fe182dfe1d2b4c7dc6
Author: Jossi Wolf <jossi@jossiwolf.de>
Date: Sun Nov 14 17:49:12 2021
Introduce `isSkipHalfExpanded` flag for Modal Bottom Sheets
If the sheet is tall enough to have a half-expanded state, this state can be disabled by passing `true` for `isSkipHalfExpanded` or by setting `ModalBottomSheetState`'s `isSkipHalfExpanded` property to `true`.
Updated the `ModalBottomSheetSample` to have a toggle for this setting.
Relnote: `ModalBottomSheetState` now has a `isSkipHalfExpanded` flag. It can be either set through the constructor or updated later on by setting `ModalBottomSheetState`'s `isSkipHalfExpanded` property to `true`. Updating `isSkipHalfExpanded`'s value causes a recomposition of the sheet.
Bug:
Test: `modalBottomSheet_showAndHide_manually_skipHalfExpanded`, `modalBottomSheet_hideBySwiping`, `ModalBottomSheetStateTest`
Change-Id: I18b866d1895f53d46c5965867f628b5eca455fa4
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ModalBottomSheetSamples.kt
al...@gmail.com
I believe this should be fixed now.
ma...@google.com
ng...@gmail.com
In which version of the library is this fix implemented? I'm using 0.24.3-alpha and isSkipHalfExpanded is not available as parameter of rememberBottomSheetNavigator()
jo...@google.com
#10, this issue tracks the implementation of the skip collapsed flag for Compose Material's ModalBottomSheetLayout. The change was released in
You are thinking of Accompanist Navigation Material for which we track the issues and requests over on GitHub. We have explored some options but haven't found a satisfactory implementation in Navigation yet since it requires a recomposition of ModalBottomSheetLayout. Follow along in this Accompanist issue to be notified about updates:
Description
material-components-androidprovides the ability to "skip collapsed", which basically allows you to skip the halfway expanded collapsed state when dismissing a fully expanded bottom sheet. (It would be good if the compose library could provide this ability as well (as our design system library currently relies on the behavior and we are aiming to have our compose code be 100% consistent with traditional views).