Verified
Status Update
No update yet.
Comments
si...@google.com
qq...@google.com
created a new issue to track the removing of paintBackground:
https://b.corp.google.com/issues/187333308
Close this one.
Close this one.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit bbe3868ee77ccefe821462aab418dc0304c5a8e4
Author: Qingqing Deng <qqd@google.com>
Date: Fri Apr 30 15:11:19 2021
[Text Selection] Draw Selection Background using DrawScope.
Bug:186674472
Test: Manually Tested
Test: ./gradlew test
RelNote: Draw Selection Background using DrawScope.
Change-Id: I73c61bfd553fca38c412d9372e3eaa6336dcd74f
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
https://android-review.googlesource.com/1692323
Branch: androidx-main
commit bbe3868ee77ccefe821462aab418dc0304c5a8e4
Author: Qingqing Deng <qqd@google.com>
Date: Fri Apr 30 15:11:19 2021
[Text Selection] Draw Selection Background using DrawScope.
Bug:186674472
Test: Manually Tested
Test: ./gradlew test
RelNote: Draw Selection Background using DrawScope.
Change-Id: I73c61bfd553fca38c412d9372e3eaa6336dcd74f
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
Description
This Paint object is used only when we need to draw a selection and I think that most of the usages of the Text composable will never draw a selection.
Can we try to refactor the code a bit in order to make this field nullable and only lazily allocate selectionPaint right before drawing the selection?