Convert non-exhaustive enum classes [187055290]

Fixed

Bug

Status Update

No update yet.

Description

ad...@google.com

created issue #1

May 3, 2021 04:26PM

Exhaustive when statements can pose a versioning challenge over time as adding an enum class value is a breaking change for existing code. Document patterns around using inline/value classes to provide versionable constants that explicitly do not permit use of exhaustive when.

Comments

ap...@google.com <ap...@google.com> #2May 6, 2021 11:54PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ap...@google.com <ap...@google.com> #3May 7, 2021 09:18PM

Thanks for the report!

si...@google.com <si...@google.com> #4May 13, 2021 05:32PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Message last modified on May 13, 2021 05:32PM

ap...@google.com <ap...@google.com> #5May 13, 2021 06:50PM

deleted

ap...@google.com <ap...@google.com> #6May 14, 2021 01:50AM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

ap...@google.com <ap...@google.com> #7May 14, 2021 02:22AM

Project: platform/frameworks/support
Branch: androidx-main

commit a4fc3c7398992fee23e6f6243707fee19adeca7d
Author: Ralston Da Silva <ralu@google.com>
Date: Wed May 12 15:48:42 2021

Replacing KeyboardType enum with an inline class

Bug: 187055290
Relnote: KeyboardType enum is replaced by an inline class.
Test: ./gradlew compose:foundation:foundation:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.foundation.text.CoreTextFieldInputServiceIntegrationTest
Change-Id: I73045de306c082ca8f6b11d44d252d0a63a407d3

M compose/foundation/foundation/api/1.0.0-beta08.txt
M compose/foundation/foundation/api/current.ignore
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_1.0.0-beta08.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_1.0.0-beta08.txt
M compose/foundation/foundation/api/restricted_current.ignore
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextFieldKeyboardTypeDemo.kt
M compose/ui/ui-text/api/1.0.0-beta08.txt
M compose/ui/ui-text/api/current.ignore
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta08.txt
M compose/ui/ui-text/api/restricted_current.ignore
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/KeyboardType.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.android.kt

https://android-review.googlesource.com/1706406

ap...@google.com <ap...@google.com> #8May 26, 2021 10:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 01363576c7b4aec2a0004c518c84d2dcbd495aea
Author: Ralston Da Silva <ralu@google.com>
Date: Thu May 13 18:05:44 2021

Replace NestedScrollSource enum with an inline class

Bug: 187055290
Relnote: NestedScrollSource enum is replaced by an inline class.
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.input.nestedscroll.NestedScrollModifierTest
Change-Id: Ie321b5864dc617b2d6382ba5d632e8037dd5c1d5

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
M compose/ui/ui/api/1.0.0-beta08.txt
M compose/ui/ui/api/current.ignore
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta08.txt
M compose/ui/ui/api/restricted_current.ignore
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/nestedscroll/NestedScrollModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationRequesterModifier.kt

https://android-review.googlesource.com/1707907

ad...@google.com <ad...@google.com> #9May 27, 2021 04:21PM

Reassigned to ra...@google.com.

This bug now has enough API change CLs linked against it that it can't really serve its original intent. Renaming and reassigning; I'll open a new one for the API guideline documentation.

ra...@google.com <ra...@google.com> Jun 6, 2021 06:50PM

Marked as fixed.