Make FragmentContainerView throw on fitSystemWindows [187304502]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

May 5, 2021 04:35PM

We FragmentContainerView was created, https://android-review.googlesource.com/c/platform/frameworks/support/+/985243/ ensured that unlike FragmentLayout that consumed all of the insets when using fitSystemWindows=true, FragmentContainerView would always dispatch the insets to child views, regardless of the value.

Now for FragmentContainerView fitSystemWindows=true is a no-op, but we should instead throw an error and indicate to the user that if they would like to handle insets they should do so at each individual fragment view.

Comments

il...@google.com <il...@google.com> May 17, 2021 10:15PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> May 18, 2021 05:59PM

Reassigned to sa...@google.com.

ap...@google.com <ap...@google.com> #2May 21, 2021 04:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

sa...@google.com <sa...@google.com> May 21, 2021 05:12PM

Marked as fixed.

il...@google.com <il...@google.com> #3May 21, 2021 06:01PM

This behavior has been changed for Fragment 1.4.0-alpha02 - FragmentContainerView was always meant to purely pass insets down to all fragments. It is then up to each Fragment on how they want to handle insets by applying fitsSystemWindows="true" to their root layout or not.

Issue 187304502