onDragStart called after onDrag [187320697]

Fixed

Bug

Status Update

No update yet.

Description

ha...@google.com

created issue #1

May 5, 2021 07:01PM

Steps to reproduce: Run the following code:

Box(
    modifier = Modifier.background(Color.Cyan).pointerInput(Unit) {
        detectDragGestures(
            onDragStart = {
                dragStarted = true
                Log.e("debugTag", "onDragStart")
            },
            onDragEnd = {
                dragStarted = false
                Log.e("debugTag", "onDragEnd")
            },
            onDragCancel = {
                dragStarted = false
                Log.e("debugTag", "onDragCancel")
            },
        ) { change, dragAmount ->
            change.consumeAllChanges()
            if (!dragStarted) {
                Log.e("debugTag", "onDrag called before onStart")
            } else {
                Log.e("debugTag", "onDrag")
            }
        }
    }
)

Drag anywhere in the Box.
Check the log, we can find that onDrag is always called once before onDragStart get called.

Example:

2021-05-05 11:59:43.653 19756-19756/androidx.compose.integration.demos E/debugTag: onDrag called before onStart
2021-05-05 11:59:43.653 19756-19756/androidx.compose.integration.demos E/debugTag: onDragStart
2021-05-05 11:59:43.669 19756-19756/androidx.compose.integration.demos E/debugTag: onDrag
2021-05-05 11:59:43.686 19756-19756/androidx.compose.integration.demos E/debugTag: onDrag
2021-05-05 11:59:43.703 19756-19756/androidx.compose.integration.demos E/debugTag: onDrag
2021-05-05 11:59:43.719 19756-19756/androidx.compose.integration.demos E/debugTag: onDrag
2021-05-05 11:59:43.736 19756-19756/androidx.compose.integration.demos E/debugTag: onDrag
2021-05-05 11:59:43.748 19756-19756/androidx.compose.integration.demos E/debugTag: onDrag
2021-05-05 11:59:43.749 19756-19756/androidx.compose.integration.demos E/debugTag: onDragEnd

Comments

an...@google.com <an...@google.com> May 20, 2021 11:26AM

Assigned to ma...@google.com.

ap...@google.com <ap...@google.com> #2May 20, 2021 12:18PM

Marked as fixed.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ch...@gmail.com <ch...@gmail.com> #3Jun 11, 2021 02:37PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

Message last modified on Jun 12, 2021 03:06AM

ma...@google.com <ma...@google.com> #4Jun 11, 2021 02:46PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

ch...@gmail.com <ch...@gmail.com> #5Jun 12, 2021 02:40AM

deleted

ma...@google.com <ma...@google.com> #6Jun 14, 2021 10:49AM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

Issue 187320697