Exception on long press in SelectionContainer with empty text [187437299]

Fixed

Bug

Status Update

No update yet.

Description

ex...@gmail.com

created issue #1

May 7, 2021 04:00PM

Compose beta06, AS Canary 14

A long press on an empty Text in a SelectionContainer causes "IllegalArgumentException: Cannot coerce value to an empty range: maximum -1 is less than minimum 0."

2021-05-07 11:46:36.129 909-909/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.exploringbinary.baseexplorer, PID: 909
    java.lang.IllegalArgumentException: Cannot coerce value to an empty range: maximum -1 is less than minimum 0.
        at kotlin.ranges.RangesKt___RangesKt.coerceIn(_Ranges.kt:1103)
        at androidx.compose.foundation.text.selection.TextSelectionDelegateKt.adjustSelection-Le-punE(TextSelectionDelegate.kt:128)
        at androidx.compose.foundation.text.selection.MultiWidgetSelectionDelegateKt.getTextSelectionInfo(MultiWidgetSelectionDelegate.kt:119)
        at androidx.compose.foundation.text.selection.MultiWidgetSelectionDelegate.getSelection-Xn-YAUg(MultiWidgetSelectionDelegate.kt:50)
        at androidx.compose.foundation.text.selection.SelectionManager.mergeSelections-IUXd7x4$foundation_release(SelectionManager.kt:343)
        at androidx.compose.foundation.text.selection.SelectionManager.updateSelection-RHHTvR4(SelectionManager.kt:612)
        at androidx.compose.foundation.text.selection.SelectionManager.access$updateSelection-RHHTvR4(SelectionManager.kt:54)
        at androidx.compose.foundation.text.selection.SelectionManager$2.invoke-d-4ec7I(SelectionManager.kt:196)
        at androidx.compose.foundation.text.selection.SelectionManager$2.invoke(SelectionManager.kt:190)
        at androidx.compose.foundation.text.selection.SelectionRegistrarImpl.notifySelectionUpdateStart-d-4ec7I(SelectionRegistrarImpl.kt:170)
        at androidx.compose.foundation.text.TextController$longPressDragObserver$1.onStart-k-4lQ0M(CoreText.kt:375)
        at androidx.compose.foundation.text.LongPressTextDragObserverKt$detectDragGesturesAfterLongPressWithObserver$2.invoke-k-4lQ0M(LongPressTextDragObserver.kt:44)
        at androidx.compose.foundation.text.LongPressTextDragObserverKt$detectDragGesturesAfterLongPressWithObserver$2.invoke(LongPressTextDragObserver.kt:43)
        at androidx.compose.foundation.gestures.DragGestureDetectorKt$detectDragGesturesAfterLongPress$5.invokeSuspend(DragGestureDetector.kt:250)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:32)
        at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:113)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

@Composable
fun IssueTBD() {
    SelectionContainer {
        Text(
            text = "",
            modifier = Modifier .fillMaxWidth() .border(BorderStroke(2.dp, color = Color.Black))
        )
    }
}

Comments

si...@google.com <si...@google.com> May 7, 2021 04:05PM

Assigned to qq...@google.com.

ex...@gmail.com <ex...@gmail.com> #2May 11, 2021 01:30AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

qq...@google.com <qq...@google.com> #3May 12, 2021 06:14AM

Created a CL to fix this problem, need to write tests.

Crash of longpress the empty text is fixed by return null selection if text is empty.
Crash of longpress the blank area is fixed by selecting the whole text content which matches Android TextView behavior.

longpress_blank.mp4

1.5 MB

Download

longpress_empty_text.mp4

1.3 MB

Download

qq...@google.com <qq...@google.com> May 21, 2021 05:05AM

Accepted by qq...@google.com.

ap...@google.com <ap...@google.com> #4May 26, 2021 07:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6bc981cbb761c52f0673ada43eb6d86b6dc8a68e
Author: Qingqing Deng <qqd@google.com>
Date: Tue May 11 22:43:51 2021

[Text Selection] Fix crashes of longpress the blank area in non-empty text.

Bug:187437299
Test: Manually tested.
Test: ./gradlew test

RelNote: Fix crashes of longpress the blank area in non-empty text.
Change-Id: I33ab5d732fc3564ec4fe99b16234a980f51684a8

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeTextSelection.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegate.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/Selectable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionRegistrar.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionRegistrarImpl.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextSelectionLongPressDragTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/SelectionManagerDragTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/SelectionManagerTest.kt

https://android-review.googlesource.com/1704965

qq...@google.com <qq...@google.com> May 27, 2021 05:11PM

Marked as fixed.

ex...@gmail.com <ex...@gmail.com> #5Jun 20, 2021 02:02PM

This is marked "fixed" but still occurs on beta09.

ex...@gmail.com <ex...@gmail.com> #6Jul 3, 2021 12:35AM

The behavior I described in comment #1 still exists on rc01. (The behavior in comment #2 appears to be fixed.) Should I write a new issue or can this one be reopened?

ha...@google.com <ha...@google.com> Jul 7, 2021 05:50PM

Status: Assigned (reopened)

si...@google.com <si...@google.com> Jul 28, 2021 06:11PM

Reassigned to an...@google.com.

si...@google.com <si...@google.com> Jul 29, 2021 08:13PM

Reassigned to ha...@google.com.

ap...@google.com <ap...@google.com> #7Aug 2, 2021 08:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 80cb74fe3f3e5c60d0a7e1da4007d54c170485ce
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Fri Jul 30 19:09:35 2021

Fix: Selection long press on empty Text crashes the app

Also refactor some test cases where setContent is not needed.
Bug: 187437299
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest

Change-Id: I3099d7cc9fb94dcc33408a15d106c5fee469a168

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegateTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegate.kt

https://android-review.googlesource.com/1783874

ha...@google.com <ha...@google.com> Aug 2, 2021 08:57PM