BadParcelableException in getParcelable after process restoration [187443158]

Fixed

Bug

Status Update

No update yet.

Description

ka...@gmail.com

created issue #1

May 9, 2021 06:17PM

Component used: Fragment Version used: 1.3.3 Devices/Android versions reproduced on: Emulator Android 10

Currently there is a crash trying to get parcelable from result after process restoration.

Setup:

There is MainActivity, FirstFragment and SecondFragment.
It is possible to navigate from FirstFragment to SecondFragment.
FirstFragment calls getParentFragmentManager().setFragmentResultListener() in onViewCreated() and listens for result.
SecondFragment calls getParentFragmentManager().setResult() on submit button click. Submit button does only that and doesn't navigate back to FirstFragment.
Result is packed in Bundle via putParcelable(). We send back ExampleClass which implements Parcelable using @kotlinx.parcelize.Parcelize.

Steps to reproduce:

Launch application, navigate to SecondFragment.
Select something, click submit button, but don't navigate back.
Make process die, for example, using Developer Options -> Background Process Limit
Open process, navigate back
FirstFragment receives result in FragmentResultListener#onFragmentResult and calls result.getParcelable().
Application crashes with android.os.BadParcelableException

Stacktrace

There two ways to avoid crash:

Call result.setClassLoader(context.classLoader) before result.getParcelable().
Set result after state restoration again.

Is this something that should be fixed on Fragment or platform side?

What is the preferred workaround for the app developers in the meantime?

Comments

ka...@gmail.com <ka...@gmail.com> #2May 10, 2021 08:12AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Sample.zip

438 KB

Download

il...@google.com <il...@google.com> May 10, 2021 04:39PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3May 10, 2021 10:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4776f596c08056c5e7234f3829de7698ad46296d
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 12:51:05 2021

Fix fragment result with parcelables

When using the fragment result API, if you put a parcelable into the
result bundle, your process dies, and your result listener attempts to
access the parcelable, you will get a class not found exception if you
do not set the classloader.

We should set the class loader on your bundle before returning the
listener callback to ensure the Parcelable classes are accesible.

RelNote: "You can now retrieve your Parcelable from the fragment result
bundle after process death."
Test: FragmentResultTest
Bug: 187443158

Change-Id: I6593233191347d9595f81268951d6f8dbb627273

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentResultTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/1701765

jb...@google.com <jb...@google.com> #4May 10, 2021 10:17PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.3.4 release via Fragment 1.4.0-alpha01.

Issue 187443158

Description

Issue summary

Comments

ka...@gmail.com <ka...@gmail.com> #2May 10, 2021 08:12AM

il...@google.com <il...@google.com> May 10, 2021 04:39PM

ap...@google.com <ap...@google.com> #3May 10, 2021 10:14PM

jb...@google.com <jb...@google.com> #4May 10, 2021 10:17PM

Add comment

Issue metadata