In Progress

Process

Status Update

No update yet.

Description

al...@google.com

created issue #1

May 6, 2021 10:12PM

The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from paging/runtime/lint-baseline.xml and address the associated issues before your next stable release.

9 instance(s) of `RestrictedApi

ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/AsyncPagedListDiffer.kt at line 131:
```
internal var mainThreadExecutor = ArchTaskExecutor.getMainThreadExecutor()
                                  ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedList.kt at line 157:
```
fetchExecutor: Executor = ArchTaskExecutor.getIOThreadExecutor()
                          ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedList.kt at line 199:
```
fetchExecutor: Executor = ArchTaskExecutor.getIOThreadExecutor()
                          ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedList.kt at line 252:
```
fetchDispatcher: CoroutineDispatcher = ArchTaskExecutor.getIOThreadExecutor()
                                       ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedList.kt at line 261:
```
    ArchTaskExecutor.getMainThreadExecutor().asCoroutineDispatcher(),
    ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedList.kt at line 304:
```
fetchDispatcher: CoroutineDispatcher = ArchTaskExecutor.getIOThreadExecutor()
                                       ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedList.kt at line 313:
```
    ArchTaskExecutor.getMainThreadExecutor().asCoroutineDispatcher(),
    ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedListBuilder.kt at line 51:
```
private var fetchDispatcher = ArchTaskExecutor.getIOThreadExecutor().asCoroutineDispatcher()
                              ~~~~~~~~~~~~~~~~
```
ArchTaskExecutor can only be called from within the same library group prefix (referenced groupId=androidx.arch.core with prefix androidx.arch from groupId=androidx.paging)

Found in src/main/java/androidx/paging/LivePagedListBuilder.kt at line 297:
```
        ArchTaskExecutor.getMainThreadExecutor().asCoroutineDispatcher(),
        ~~~~~~~~~~~~~~~~
```

Comments

al...@google.com <al...@google.com> #2May 6, 2021 10:13PM

Hello, can you please attach a sample that reproduces your error?

du...@google.com <du...@google.com> #3May 7, 2021 01:10AM

I’ve attached two screen recordings demonstrating the mediator's behavior during the first and second launches after installation. Additionally, https://gist.github.com/yatiksihag01/20106aa4855bd438e3eb982034d4bb7d is link to a GitHub Gist containing the code for my remote mediator file for your reference.

al...@google.com <al...@google.com> #4May 7, 2021 01:11AM

Based on first_launch_after_installation.mp4, your paging state is indeed showing null for nextKey, so it makes sense that Paging concluded there are no more items to load.

So I think the question is why the PagingState contains only an empty page and null values. My guess is either

RemoteMediator REFRESH actually returned empty data - what is the returned allNewsItems value on initial REFRESH?
RemoteMediator REFRESH successfully loaded data and inserted it into database, but Paging hasn't processed that yet by the time Append is triggered, so PagingState is empty.

The second case doesn't seem likely though.

If you attach an executable app, I can look into this further.

Otherwise, you may gain more insight through Paging logs with adb shell setprop log.tag.Paging VERBOSE. You can also try implementing RemoteKeys in this codelab which addresses possible races between Refresh and subsequent loads.

du...@google.com <du...@google.com> #5May 7, 2021 05:22PM

Hey! I ran into this same issue. It is in fact the second case you mentioned and is documented here.

I've published a repo reproducing the issue and filed a ticket proposing how this could be changed.

al...@google.com <al...@google.com> #6May 7, 2021 05:35PM

LIBRARY_GROUP_PREFIX should cover all of androidx.

du...@google.com <du...@google.com> #7May 7, 2021 05:55PM

It's already set to LIBRARY_GROUP_PREFIX, and updating baseline doesn't post any changes.

al...@google.com <al...@google.com> #8May 7, 2021 06:17PM

Reassigned to bu...@google.com.

        fun sameLibraryGroupPrefix(group1: String, group2: String): Boolean {
            // TODO: Allow group1.startsWith(group2) || group2.startsWith(group1) ?

            if (group1 == group2) {
                return true
            }

            val i1 = group1.lastIndexOf('.')
            val i2 = group2.lastIndexOf('.')
            if (i2 != i1 || i1 == -1) {
                return false
            }

            return group1.regionMatches(0, group2, 0, i1)
        }

Looks like they forgot to make it support groups with more than two levels. The TODO here would cover our case. Filed b/187523902 to block this issue.

du...@google.com <du...@google.com> #9May 7, 2021 07:27PM

Thanks for looking into this!

bu...@google.com <bu...@google.com> #10May 7, 2021 08:14PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait for

b/187523902

to be resolved and then assign the bug to dustinlam@google.com.

Bugjuggler:

b/187523902

-> assigned to dustinlam@google.com

IssueTracker

Fix 9 lint baseline suppression(s) of RestrictedApi

Status Update

Description

9 instance(s) of `RestrictedApi

Comments

al...@google.com <al...@google.com> #2May 6, 2021 10:13PM

du...@google.com <du...@google.com> #3May 7, 2021 01:10AM

al...@google.com <al...@google.com> #4May 7, 2021 01:11AM

du...@google.com <du...@google.com> #5May 7, 2021 05:22PM

al...@google.com <al...@google.com> #6May 7, 2021 05:35PM

du...@google.com <du...@google.com> #7May 7, 2021 05:55PM

al...@google.com <al...@google.com> #8May 7, 2021 06:17PM

du...@google.com <du...@google.com> #9May 7, 2021 07:27PM

bu...@google.com <bu...@google.com> #10May 7, 2021 08:14PM

Issue 187446947

Description

9 instance(s) of `RestrictedApi

Issue summary

Comments

al...@google.com <al...@google.com> #2May 6, 2021 10:13PM

du...@google.com <du...@google.com> #3May 7, 2021 01:10AM

al...@google.com <al...@google.com> #4May 7, 2021 01:11AM

du...@google.com <du...@google.com> #5May 7, 2021 05:22PM

al...@google.com <al...@google.com> #6May 7, 2021 05:35PM

du...@google.com <du...@google.com> #7May 7, 2021 05:55PM

al...@google.com <al...@google.com> #8May 7, 2021 06:17PM

du...@google.com <du...@google.com> #9May 7, 2021 07:27PM

bu...@google.com <bu...@google.com> #10May 7, 2021 08:14PM

Add comment

Issue metadata