DialogFragmentCallbacksDetector lint check crashing lint [187524311]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

May 7, 2021 06:02PM

Component used: Fragment Version used: (latest 1.4.0-SNAPSHOT) Devices/Android versions reproduced on: N/A (host lint crash)

A new lint check was added to androidx.fragment (DialogFragmentCallbacksDetector) which is crashing lint when run. It looks like it crashes if a javafile has a class/interface with no supertype?

Here is an abridged stacktrace:

java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:372)
at java.base/java.util.ArrayList.get(ArrayList.java:458)
at androidx.fragment.lint.OnCreateDialogIncorrectCallbackDetector$UastHandler.visitClass(OnCreateDialogIncorrectCallbackDetector.kt:84)
...

Full stack trace here. Full chromium compile output here (it's a bit noisy since it crashes on a lot of .java files).

Comments

il...@google.com <il...@google.com> May 7, 2021 06:13PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #2May 10, 2021 07:17PM

I proposed this which I think it is better than the actual behavior, and could let the developers work with more room to be creative.

https://code.google.com/p/android/issues/detail?id=58318

mh...@google.com <mh...@google.com> #3May 10, 2021 07:32PM

The presentation link doesn't work.

ap...@google.com <ap...@google.com> #4May 11, 2021 01:31AM

In Custom Notification Layouts section of the Notification API Guides, it states: "The height available for a custom notification layout depends on the notification view. Normal view layouts are limited to 64 dp, and expanded view layouts are limited to 256 dp". I guess it means the width is 512 dp and the height is 256 dp (if following the 2:1 aspect ratio)?

http://developer.android.com/guide/topics/ui/notifiers/notifications.html#CustomNotification

jb...@google.com <jb...@google.com> #5May 11, 2021 01:44AM

Marked as fixed.

Here is the presentation:

http://commondatastorage.googleapis.com/io2012/presentations/live%20to%20website/105.pdf

jo...@gmail.com <jo...@gmail.com> #6May 24, 2021 04:31PM

https://code.google.com/p/android/issues/detail?id=58318http://developer.android.com/reference/android/app/Notification.BigPictureStyle.html#bigPicture(android.graphics.Bitmap)

il...@google.com <il...@google.com> #7Jun 1, 2021 07:11PM

Any update on this?

de...@gmail.com <de...@gmail.com> #8Jun 12, 2022 12:11PM

Comment has been deleted.

Message last modified on Jun 12, 2022 12:12PM

de...@gmail.com <de...@gmail.com> #9Jun 12, 2022 12:14PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing