Scaffold and BottomSheetScaffold top bar elevation handling Inconsistency [187771422]

Fixed

Bug

Status Update

No update yet.

Description

ze...@gmail.com

created issue #1

May 11, 2021 10:39AM

Jetpack Compose release version: 1.0.0-beta06

Android Studio Build: Android Studio Arctic Fox | 2020.3.1 Canary 15

Build #AI-203.7717.56.2031.7321754, built on April 29, 2021

Runtime version: 11.0.10+0-b96-7281165 x86_64

It seems that BottomSheetScaffold's content is overlapping topBar's elevation. Minimal code to reproduce:

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.height
import androidx.compose.material.*
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp

@Composable
fun GoodElevation() {
    Scaffold(
        topBar = {
            TopAppBar(backgroundColor = MaterialTheme.colors.background) { Text(text = "The good") }
        },
    ) {
        Surface(modifier = Modifier.fillMaxSize()) {}
    }
}

@Composable
fun BadElevation() {
    val scaffoldState = rememberBottomSheetScaffoldState()
    BottomSheetScaffold(
        scaffoldState = scaffoldState,
        topBar = {
            TopAppBar(backgroundColor = MaterialTheme.colors.background) { Text(text = "The bad") }
        },
        sheetContent = {
            Box(modifier = Modifier.height(250.dp)) { Text("whatever") }
        }
    ) {
        Surface(modifier = Modifier.fillMaxSize()) {}
    }
}

@Preview
@Composable
fun TheGoodPreview() {
    GoodElevation()
}

@Preview
@Composable
fun TheBadPreview() {
    BadElevation()
}

Zrzut ekranu 2021-05-11 o 12.33.13.png

8.3 KB

View

Download

Zrzut ekranu 2021-05-11 o 12.33.18.png

9 KB

View

Download

Comments

ma...@google.com <ma...@google.com> May 11, 2021 02:13PM

Assigned to je...@google.com.

ni...@google.com <ni...@google.com> #2Jun 15, 2021 01:09PM

Status: New

This should be moved to the Android Public Tracker > Text component, but I don't have permissions so I'm redirecting to the appropriate owner.

ma...@google.com <ma...@google.com> #3Jun 17, 2021 05:27PM

Assigned to je...@google.com.

So after updating to 1.4.1 and all deps too, the crash was a little different see below.

The repro for that one is easy

create a new app from AS 7.1 RC 1
update deps to (Appcompat 1.4.1/Material 1.5.0/Constraintlayout 2.1.3)
Add 2 textViews

    <TextView
        android:id="@+id/text1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Hello World!"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintTop_toTopOf="parent" />

    <TextView
        android:id="@+id/text2"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Hello World!"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/text1" />```

In onCreate:

        val t1 = findViewById<TextView>(R.id.text1)
        val t2 = findViewById<TextView>(R.id.text2)

        val charBuffer1 = CharArrayBuffer("AAA".toCharArray())
        charBuffer1.sizeCopied = 3
        val charBuffer2 = CharArrayBuffer("AAA".toCharArray())
        charBuffer2.sizeCopied = 3

        t1.setText(charBuffer1.data, 0, charBuffer1.sizeCopied)
        t2.setText(charBuffer2.data, 0, charBuffer2.sizeCopied)

Run see the texts updated then crash with the following. (Tested on P6 Pro Android 12)

Process: org.debug.myapplication, PID: 32493
    java.lang.NullPointerException: src == null
        at java.lang.System.arraycopy(Native Method)
        at android.widget.TextView$CharWrapper.getChars(TextView.java:13588)
        at android.text.TextUtils.getChars(TextUtils.java:155)
        at android.text.BoringLayout.hasAnyInterestingChars(BoringLayout.java:314)
        at android.text.BoringLayout.isBoring(BoringLayout.java:340)
        at android.widget.TextView.onMeasure(TextView.java:9413)
        at androidx.appcompat.widget.AppCompatTextView.onMeasure(AppCompatTextView.java:607)
        at android.view.View.measure(View.java:25774)
        at androidx.constraintlayout.widget.ConstraintLayout$Measurer.measure(ConstraintLayout.java:811)
        at androidx.constraintlayout.core.widgets.analyzer.BasicMeasure.measure(BasicMeasure.java:466)
        at androidx.constraintlayout.core.widgets.analyzer.BasicMeasure.measureChildren(BasicMeasure.java:134)
        at androidx.constraintlayout.core.widgets.analyzer.BasicMeasure.solverMeasure(BasicMeasure.java:278)
        at androidx.constraintlayout.core.widgets.ConstraintWidgetContainer.measure(ConstraintWidgetContainer.java:120)
        at androidx.constraintlayout.widget.ConstraintLayout.resolveSystem(ConstraintLayout.java:1594)
        at androidx.constraintlayout.widget.ConstraintLayout.onMeasure(ConstraintLayout.java:1708)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at androidx.appcompat.widget.ContentFrameLayout.onMeasure(ContentFrameLayout.java:145)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at androidx.appcompat.widget.ActionBarOverlayLayout.onMeasure(ActionBarOverlayLayout.java:496)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
        at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
        at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at com.android.internal.policy.DecorView.onMeasure(DecorView.java:761)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:3628)
        at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:2424)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2694)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2143)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8665)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:780)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

jo...@google.com <jo...@google.com> Apr 8, 2022 05:56PM

Reassigned to jo...@google.com.

jo...@google.com <jo...@google.com> Apr 11, 2022 05:25PM

Accepted by jo...@google.com.

ap...@google.com <ap...@google.com> #4May 25, 2022 08:48AM

since it is possibly related to emojicompat reassigned

jo...@google.com <jo...@google.com> May 25, 2022 09:46AM

Marked as fixed, reassigned to jo...@google.com.