Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ni...@google.com <ni...@google.com> #2
Resetting assignee to `None` in preparation of the triage bash on Thursday June 17th. Please reach out to nickanthony@ if you have any questions.
ma...@google.com <ma...@google.com> #3
moving particular sheets implementation bugs under material alias, keeping swipeable design-related issues to malkov@
jo...@google.com <jo...@google.com>
jo...@google.com <jo...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit ee16c2fa8bfbd261a382f0c7fc51965357bb8155
Author: Jossi Wolf <jossiwolf@google.com>
Date: Tue Apr 12 16:59:15 2022
Draw order & Snackbar placement for BottomSheetScaffold
Previously, we were drawing the layout's body content over the top bar's elevation, but we now respect the draw order.
BottomSheetScaffold now also takes the sheet's state into account when placing Snackbars: in the collapsed state, Snackbars are placed above the sheet and FAB; in the expanded state, Snackbars are anchored to the sheet's bottom.
We are now also explicit about the case of sheetHeight == peekHeight, only having a collapsed anchor/state in this case. We are looking to explore different structures (i.e. a list) to represent multiple associated values for anchors.
Relnote: Fixed a bug where BottomSheetScaffold was drawing over the top app bar's shadow. BottomSheetScaffold now also takes the sheet's state into account when placing Snackbars: in the collapsed state, Snackbars are placed above the sheet and FAB; in the expanded state, Snackbars are anchored to the sheet's bottom.
Bug: b/187771422
Test: Added a few tests around snackbar positioning and expected anchors in case sheetHeight == peekHeight, removed bottomSheetScaffold_topAppBarIsDrawnOnTopOfContent and created a screenshot test as replacement
Change-Id: Ia80b5d1ebcd4c86431eab22a985ab2b1fa824843
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
https://android-review.googlesource.com/2062235
Branch: androidx-main
commit ee16c2fa8bfbd261a382f0c7fc51965357bb8155
Author: Jossi Wolf <jossiwolf@google.com>
Date: Tue Apr 12 16:59:15 2022
Draw order & Snackbar placement for BottomSheetScaffold
Previously, we were drawing the layout's body content over the top bar's elevation, but we now respect the draw order.
BottomSheetScaffold now also takes the sheet's state into account when placing Snackbars: in the collapsed state, Snackbars are placed above the sheet and FAB; in the expanded state, Snackbars are anchored to the sheet's bottom.
We are now also explicit about the case of sheetHeight == peekHeight, only having a collapsed anchor/state in this case. We are looking to explore different structures (i.e. a list) to represent multiple associated values for anchors.
Relnote: Fixed a bug where BottomSheetScaffold was drawing over the top app bar's shadow. BottomSheetScaffold now also takes the sheet's state into account when placing Snackbars: in the collapsed state, Snackbars are placed above the sheet and FAB; in the expanded state, Snackbars are anchored to the sheet's bottom.
Bug:
Test: Added a few tests around snackbar positioning and expected anchors in case sheetHeight == peekHeight, removed bottomSheetScaffold_topAppBarIsDrawnOnTopOfContent and created a screenshot test as replacement
Change-Id: Ia80b5d1ebcd4c86431eab22a985ab2b1fa824843
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
Description
Jetpack Compose release version: 1.0.0-beta06
Android Studio Build: Android Studio Arctic Fox | 2020.3.1 Canary 15
Build #AI-203.7717.56.2031.7321754, built on April 29, 2021
Runtime version: 11.0.10+0-b96-7281165 x86_64
It seems that BottomSheetScaffold's content is overlapping topBar's elevation. Minimal code to reproduce: