Lint crashes in PrivateApiDetector when using lint.do.not.reuse.uast.env [187851920]

Fixed

Bug

Status Update

No update yet.

Description

ws...@gmail.com

created issue #1

May 12, 2021 07:19PM

AGP 4.2.0

As suggested in https://issuetracker.google.com/issues/158777858#comment22, we tried to turn on systemProp.lint.do.not.reuse.uast.env=true to work around the bug in that issue.

That gave us a new error which does not happen without this workaround:

/our/repo/SamsungUtils.java: Error: Unexpected failure during lint analysis of SamsungUtils.java (this is a bug in lint or one of the libraries it depends on)

Message: Element: class com.intellij.psi.impl.source.PsiJavaCodeReferenceElementImpl #JAVA  because: project is disposed: com.intellij.mock.MockProject@29d02394
invalidated at: no info

The crash seems to involve the detector com.android.tools.lint.checks.PrivateApiDetector.
You can try disabling it with something like this:
    android {
        lintOptions {
            disable "BlockedPrivateApi", "DiscouragedPrivateApi", "PrivateApi", "SoonBlockedPrivateApi"
        }
    }

Stack: PsiInvalidElementAccessException:PsiUtilCore.ensureValid(PsiUtilCore.java:477)←PsiJavaCodeReferenceElementImpl.getKindEnum(PsiJavaCodeReferenceElementImpl.java:91)←PsiJavaCodeReferenceElementImpl.getCanonicalText(PsiJavaCodeReferenceElementImpl.java:284)←PsiJavaCodeReferenceElementImpl.getCanonicalText(PsiJavaCodeReferenceElementImpl.java:279)←PsiClassReferenceType.getText(PsiClassReferenceType.java:241)←PsiClassReferenceType.getCanonicalText(PsiClassReferenceType.java:228)←PsiClassType$Stub.getCanonicalText(PsiClassType.java:352)←PrivateApiDetector.getJavaClassFromMemberLookup(PrivateApiDetector.kt:304)

linterror.log

2.7 KB

View

Download

Comments

gh...@google.com <gh...@google.com> #2May 13, 2021 12:42PM

Assigned to gh...@google.com.

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

gh...@google.com <gh...@google.com> #3May 13, 2021 12:48PM

Actually, I think I found the cause. The full stack trace will probably not be needed.

gh...@google.com <gh...@google.com> #4May 13, 2021 01:43PM

Reproducible in a multi-module project with the following code snippet (which triggers a particular code path in PrivateApiDetector):

val activityClass = Class.forName("android.app.Activity")
val bundleClass = Class.forName("android.os.Bundle")
val method = activityClass.getDeclaredMethod("dispatchActivityPostCreated", bundleClass)

The root cause is that PrivateApiDetector caches the ideaProject here:

override fun beforeCheckRootProject(context: Context) {
    ...
    psiFactory = PsiElementFactory.getInstance(context.project.ideaProject)
}

and this caching is invalid when lint.do.not.reuse.uast.env is enabled.

I'm hoping to create a fix in time for AGP 4.2.2.

gh...@google.com <gh...@google.com> #5May 13, 2021 06:26PM

Marked as fixed.

The fix, Change Ib7d4d6c9e, should land in AGP 4.2.2.

And to confirm, lint.do.not.reuse.uast.env should no longer be needed at all in AGP 7.0+.

Thank you for the report!

Issue 187851920

Description

Issue summary

Comments

gh...@google.com <gh...@google.com> #2May 13, 2021 12:42PM

gh...@google.com <gh...@google.com> #3May 13, 2021 12:48PM

gh...@google.com <gh...@google.com> #4May 13, 2021 01:43PM

gh...@google.com <gh...@google.com> #5May 13, 2021 06:26PM

Add comment

Issue metadata