Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 74dde5c6effb40f5bf07d113721ad7930c1f64a3
Author: Sanura N'Jaka <sanura@google.com>
Date: Thu May 13 16:10:55 2021
Log FragmentStrictMode violations when debugging enabled
Updating FragmentStrictMode to always send a DEBUG log
message with the whenever developers have specifically
enabled debug logging, regardless of what policy is
being used.
RelNote: "When logging is enabled, `FragmentStrictMode`
will now output every violation to logcat, regardless
of what policy is being used."
Bug: 187872638
Test: ./gradlew checkApi
Change-Id: I02df6361e86124563757d152993aba6468d400f3
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
https://android-review.googlesource.com/1706925
Branch: androidx-main
commit 74dde5c6effb40f5bf07d113721ad7930c1f64a3
Author: Sanura N'Jaka <sanura@google.com>
Date: Thu May 13 16:10:55 2021
Log FragmentStrictMode violations when debugging enabled
Updating FragmentStrictMode to always send a DEBUG log
message with the whenever developers have specifically
enabled debug logging, regardless of what policy is
being used.
RelNote: "When logging is enabled, `FragmentStrictMode`
will now output every violation to logcat, regardless
of what policy is being used."
Bug: 187872638
Test: ./gradlew checkApi
Change-Id: I02df6361e86124563757d152993aba6468d400f3
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
il...@google.com
This has been fixed internally and will be released in Fragment 1.4.0-alpha02.
Description
Component used: Fragment Version used: 1.4.0-alpha01
Developers can decide what type of penalties they would like Fragment StrictMode to output, from
penaltyLog()topenaltyDeath(). However, if developers have specifically enabled debug logging viaFragmentManager.enableDebugLogging(true)or via theadb shell setprop log.tag.FragmentManager VERBOSE(orDEBUG), we should always output every violation to logcat with theFragmentManager.TAGasLog.d(), no matter what policy is used.This is ensure that debug logging will inform those debugging Fragments of potential issues that may affect the behavior of Fragments.
The internal helper of
FragmentManager.isLoggingEnabled(Log.DEBUG)can be used to determine whether we should output these debug log violations. This output should happen before any FragmentStrictMode policy specific logging/listeners/death. IfpenaltyLog()is used and you're debug logging, both log messages should appear (they should be independent from one another).