[Feature Request] Allow layoutId in AppCompatDialogFragment constructor [188119987]

Fixed

Bug

Status Update

No update yet.

Description

4b...@gmail.com

created issue #1

May 15, 2021 10:52PM

Component used: AppCompatDialogFragment
Version used: 1.2.0
Devices/Android versions reproduced on: All

Hi,

Would it be possible to add a constructor with the layout resource in AppCompatDialogFragment just like it is possible with regular DialogFragment?

Thanks.

Comments

al...@google.com <al...@google.com> May 25, 2021 05:59PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #2May 26, 2021 03:40PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 93a3bc7ac8b0efc383523ecc09519a9822400421
Author: Alan Viverette <alanv@google.com>
Date: Tue May 25 11:05:37 2021

Parity for super constructor that takes a layout ID

Relnote: "Added AppCompatDialogFragment constructor that takes a layout ID"
Fixes: 188119987
Test: AppCompatDialogFragmentTest
Change-Id: Icbf22da2f79aa902756a8e2e319efa5a0d92bdde

M appcompat/appcompat/api/current.txt
M appcompat/appcompat/api/public_plus_experimental_current.txt
M appcompat/appcompat/api/restricted_current.txt
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/AppCompatDialogFragmentTest.java
D appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/DialogTestCase.java
A appcompat/appcompat/src/androidTest/res/layout/dialog_layout.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDialogFragment.java

https://android-review.googlesource.com/1717811

Issue 188119987

Description

Issue summary

Comments

al...@google.com <al...@google.com> May 25, 2021 05:59PM

ap...@google.com <ap...@google.com> #2May 26, 2021 03:40PM

Add comment

Issue metadata