IssueTracker

Triage notes: Still P3, still a real issue. Compat issue.

I am not certain what could cause this, CC'ing adamp@ who might have an idea.

Can you provide any more context other than the stack trace?

I reproduced this reliably on Compose for Desktop on Ubuntu (Windows/macOs don't crash): https://github.com/JetBrains/compose-jb/issues/991

Will try to make a minimal reproducer

Hey all, a little bit late to the party. I was able to reproduce a similar error.

Android studio: Android Studio Bumblebee | 2021.1.1

Here are my dependencies where composeVersion is 1.1.0-rc03. Also the Kotlin version is 1.6.10.

dependencies {
    implementation 'androidx.core:core-ktx:1.7.0'
    implementation "androidx.compose.ui:ui:$compose_version"
    implementation "androidx.compose.material:material:$compose_version"
    implementation "androidx.compose.ui:ui-tooling-preview:$compose_version"
    implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.3.1'
    implementation 'androidx.activity:activity-compose:1.3.1'
    testImplementation 'junit:junit:4.13.2'
    androidTestImplementation 'androidx.test.ext:junit:1.1.3'
    androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
    androidTestImplementation "androidx.compose.ui:ui-test-junit4:$compose_version"
    debugImplementation "androidx.compose.ui:ui-tooling:$compose_version"
    androidTestUtil 'androidx.test:orchestrator:1.4.1'
}

The setup is pretty slim (the project is attached to this message too):

data class Data(val id: Int, val text: String)
sealed class State {
  object Initial : State()
  class Loaded(val data: List<Data>) : State()
}
enum class Order {
  NORMAL,
  REVERSED
}

class MainActivity : ComponentActivity() {
  override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)

    setContent {
      val listState = rememberLazyListState()
      val (order, setOrder) = remember { mutableStateOf(Order.NORMAL) }
      val (sortDialogDisplayed, setSortDialogDisplayed) = remember { mutableStateOf(false) }
      val state by produceState<State>(initialValue = State.Initial, key1 = order) {
        delay(300)
        value = State.Loaded(
          (if (order == Order.REVERSED) 30 downTo 0 else 0..30).map { Data(it, "Data: $it") }
        )
      }

      LaunchedEffect(state) {
        if (state is State.Loaded) {
          runCatching { listState.scrollToItem(0) }
            .onFailure { it.printStackTrace() }
        }
      }

      if (sortDialogDisplayed) {
        Dialog(onDismissRequest = { setSortDialogDisplayed(false) }) {
          Column {
            Order.values().forEach { order ->
              Button(
                onClick = { setOrder(order); setSortDialogDisplayed(false) },
                content = { Text(text = order.name) }
              )
            }
          }
        }
      }

      MyApplicationTheme {
        when (state) {
          State.Initial -> {}
          is State.Loaded -> Scaffold(
            topBar = {
              TopAppBar(
                title = { Text(text = "Title") },
                actions = {
                  Button(
                    onClick = { setSortDialogDisplayed(true) },
                    content = { Text(text = "Sort") }
                  )
                }
              )
            }
          ) {
            LazyColumn(
              modifier = Modifier
                .semantics { contentDescription = "List" }
                .fillMaxSize(),
              state = listState
            ) {
              itemsIndexed((state as State.Loaded).data) { index, item ->
                if (index == 0) {
                  Text(
                    modifier = Modifier
                      .height(48.dp)
                      .fillMaxWidth()
                      .background(Color.Gray),
                    text = "Sort order: $order"
                  )
                }
                Text(
                  modifier = Modifier
                    .height(48.dp)
                    .fillMaxWidth(),
                  text = item.text
                )
              }
            }
          }
        }
      }
    }
  }
}

Now while this works properly if the app is running normaly it fails under this UI test:

@RunWith(AndroidJUnit4::class)
class SortToggleTest {
  @get:Rule
  val rule = createEmptyComposeRule()

  private lateinit var activityScenario: ActivityScenario<MainActivity>

  private fun start() {
    activityScenario = ActivityScenario.launch(
      Intent(InstrumentationRegistry.getInstrumentation().targetContext, MainActivity::class.java)
    )
  }

  @Test
  fun testSortToggle() {
    start()

    await(hasText("Sort order: NORMAL"))
    await(hasContentDescription("List")).performScrollToIndex(20)
    await(hasText("Sort")).performClick()
    await(hasText("REVERSED")).performClick()
    await(hasText("Sort order: REVERSED"))
  }

  private fun await(
    matcher: SemanticsMatcher,
    useUnmergedTree: Boolean = false,
    timeout: Long = 10000L
  ): SemanticsNodeInteraction {
    rule.waitUntil(timeout) { runCatching { rule.onNode(matcher).assertIsDisplayed() }.isSuccess }
    return rule.onNode(matcher, useUnmergedTree = useUnmergedTree)
  }
}

The stack trace that I am getting is the following when the app is under test:

java.lang.IllegalStateException: pending composition has not been applied
    at androidx.compose.runtime.CompositionImpl.drainPendingModificationsForCompositionLocked(Composition.kt:444)
    at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:477)
    at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:748)
    at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Composer.kt:2987)
    at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Composer.kt:2987)
    at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:433)
    at androidx.compose.ui.layout.SubcomposeLayoutState.subcomposeInto(SubcomposeLayout.kt:269)
    at androidx.compose.ui.layout.SubcomposeLayoutState.access$subcomposeInto(SubcomposeLayout.kt:154)
    at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2.invoke(SubcomposeLayout.kt:244)
    at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2.invoke(SubcomposeLayout.kt:241)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver.withNoObservations(SnapshotStateObserver.kt:142)
    at androidx.compose.ui.node.OwnerSnapshotObserver.withNoSnapshotReadObservation$ui_release(OwnerSnapshotObserver.kt:55)
    at androidx.compose.ui.node.LayoutNode.withNoSnapshotReadObservation$ui_release(LayoutNode.kt:1175)
    at androidx.compose.ui.layout.SubcomposeLayoutState.subcompose(SubcomposeLayout.kt:241)
    at androidx.compose.ui.layout.SubcomposeLayoutState.subcompose(SubcomposeLayout.kt:235)
    at androidx.compose.ui.layout.SubcomposeLayoutState.subcompose$ui_release(SubcomposeLayout.kt:224)
    at androidx.compose.ui.layout.SubcomposeLayoutState$Scope.subcompose(SubcomposeLayout.kt:490)
    at androidx.compose.foundation.lazy.layout.LazyLayoutPlaceablesProvider.getAndMeasure-0kLqBqw(LazyMeasurePolicy.kt:58)
    at androidx.compose.foundation.lazy.list.LazyMeasuredItemProvider.getAndMeasure-oA9-DU0(LazyMeasuredItemProvider.kt:45)
    at androidx.compose.foundation.lazy.list.LazyListMeasureKt.measureLazyList-wroFCeY(LazyListMeasure.kt:145)
    at androidx.compose.foundation.lazy.list.LazyListKt$rememberLazyListMeasurePolicy$1$1.measure-3p2s80s(LazyList.kt:259)
    at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$2.invoke-0kLqBqw(LazyLayout.kt:55)
    at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$2.invoke(LazyLayout.kt:44)
    at androidx.compose.ui.layout.SubcomposeLayoutState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:355)
    at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:55)
    at androidx.compose.ui.node.DelegatingLayoutNodeWrapper.measure-BRTryo0(DelegatingLayoutNodeWrapper.kt:131)
10169(com.test.gestures) identical 4 lines
    at androidx.compose.ui.node.DelegatingLayoutNodeWrapper.measure-BRTryo0(DelegatingLayoutNodeWrapper.kt:131)
    at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:306)
    at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:39)
    at androidx.compose.ui.node.DelegatingLayoutNodeWrapper.measure-BRTryo0(DelegatingLayoutNodeWrapper.kt:131)
    at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)
    at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:39)
    at androidx.compose.ui.node.DelegatingLayoutNodeWrapper.measure-BRTryo0(DelegatingLayoutNodeWrapper.kt:131)
    at androidx.compose.ui.node.OuterMeasurablePlaceable$remeasure$2.invoke(OuterMeasurablePlaceable.kt:99)
    at androidx.compose.ui.node.OuterMeasurablePlaceable$remeasure$2.invoke(OuterMeasurablePlaceable.kt:98)
    at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:1798)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:121)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:88)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:76)
    at androidx.compose.ui.node.OuterMeasurablePlaceable.remeasure-BRTryo0(OuterMeasurablePlaceable.kt:98)
    at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1317)
    at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1313)
    at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure(MeasureAndLayoutDelegate.kt:170)
    at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:228)
    at androidx.compose.ui.node.MeasureAndLayoutDelegate.access$remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:38)
    at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:201)
    at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout(AndroidComposeView.android.kt:662)
    at androidx.compose.ui.node.Owner$DefaultImpls.measureAndLayout$default(Owner.kt:182)
    at androidx.compose.ui.node.LayoutNode.forceRemeasure(LayoutNode.kt:1339)
    at androidx.compose.foundation.lazy.layout.LazyLayoutState.remeasure(LazyLayoutState.kt:54)
    at androidx.compose.foundation.lazy.LazyListState.snapToItemIndexInternal$foundation_release(LazyListState.kt:202)
    at androidx.compose.foundation.lazy.LazyListState$scrollToItem$2.invokeSuspend(LazyListState.kt:194)
    at androidx.compose.foundation.lazy.LazyListState$scrollToItem$2.invoke(Unknown Source:8)
    at androidx.compose.foundation.lazy.LazyListState$scrollToItem$2.invoke(Unknown Source:4)
    at androidx.compose.foundation.gestures.DefaultScrollableState$scroll$2$1.invokeSuspend(ScrollableState.kt:148)
    at androidx.compose.foundation.gestures.DefaultScrollableState$scroll$2$1.invoke(Unknown Source:8)
    at androidx.compose.foundation.gestures.DefaultScrollableState$scroll$2$1.invoke(Unknown Source:4)
    at androidx.compose.foundation.MutatorMutex$mutateWith$2.invokeSuspend(MutatorMutex.kt:160)
    at androidx.compose.foundation.MutatorMutex$mutateWith$2.invoke(Unknown Source:8)
    at androidx.compose.foundation.MutatorMutex$mutateWith$2.invoke(Unknown Source:4)
    at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:89)
    at kotlinx.coroutines.CoroutineScopeKt.coroutineScope(CoroutineScope.kt:264)
    at androidx.compose.foundation.MutatorMutex.mutateWith(MutatorMutex.kt:153)
    at androidx.compose.foundation.gestures.DefaultScrollableState$scroll$2.invokeSuspend(ScrollableState.kt:145)
    at androidx.compose.foundation.gestures.DefaultScrollableState$scroll$2.invoke(Unknown Source:8)
    at androidx.compose.foundation.gestures.DefaultScrollableState$scroll$2.invoke(Unknown Source:4)
    at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:89)
    at kotlinx.coroutines.CoroutineScopeKt.coroutineScope(CoroutineScope.kt:264)
    at androidx.compose.foundation.gestures.DefaultScrollableState.scroll(ScrollableState.kt:144)
    at androidx.compose.foundation.gestures.ScrollableState$DefaultImpls.scroll$default(ScrollableState.kt:51)
    at androidx.compose.foundation.lazy.LazyListState.scrollToItem(LazyListState.kt:193)
    at androidx.compose.foundation.lazy.LazyListState.scrollToItem$default(LazyListState.kt:188)
    at com.test.gestures.ComposableSingletons$MainActivityKt$lambda-3$1$3$1.invokeSuspend(MainActivity.kt:53)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
    at kotlinx.coroutines.test.TestCoroutineDispatcher.dispatch(TestCoroutineDispatcher.kt:50)
    at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:322)
    at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:30)
    at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable$default(Cancellable.kt:25)
    at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:110)
    at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126)
    at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56)
    at kotlinx.coroutines.BuildersKt.launch(Unknown Source:1)
    at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch$default(Builders.common.kt:47)
    at kotlinx.coroutines.BuildersKt.launch$default(Unknown Source:1)
    at androidx.compose.runtime.LaunchedEffectImpl.onRemembered(Effects.kt:288)
    at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchRememberObservers(Composition.kt:802)
    at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:647)
    at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:488)
    at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:425)
    at androidx.compose.ui.test.TestMonotonicFrameClock$Awaiter.runFrame(TestMonotonicFrameClock.jvm.kt:86)
    at androidx.compose.ui.test.TestMonotonicFrameClock$maybeLaunchTickRunner$1.invokeSuspend(TestMonotonicFrameClock.jvm.kt:111)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:234)
    at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:166)
    at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:397)
    at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:431)
    at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:420)
    at kotlinx.coroutines.CancellableContinuationImpl.resumeUndispatched(CancellableContinuationImpl.kt:518)
    at kotlinx.coroutines.test.TestCoroutineDispatcher$scheduleResumeAfterDelay$1.invoke(TestCoroutineDispatcher.kt:64)
    at kotlinx.coroutines.test.TestCoroutineDispatcher$scheduleResumeAfterDelay$1.invoke(TestCoroutineDispatcher.kt:64)
    at kotlinx.coroutines.test.CancellableContinuationRunnable.run(TestCoroutineDispatcher.kt:194)
    at kotlinx.coroutines.test.TimedRunnable.run(Unknown Source:2)
    at kotlinx.coroutines.test.TestCoroutineDispatcher.doActionsUntil(TestCoroutineDispatcher.kt:103)
    at kotlinx.coroutines.test.TestCoroutineDispatcher.advanceUntilTime(TestCoroutineDispatcher.kt:123)
    at kotlinx.coroutines.test.TestCoroutineDispatcher.advanceTimeBy(TestCoroutineDispatcher.kt:113)
    at androidx.compose.ui.test.junit4.AbstractMainTestClock$advanceDispatcher$1.invoke(AbstractMainTestClock.kt:68)
    at androidx.compose.ui.test.junit4.AbstractMainTestClock$advanceDispatcher$1.invoke(AbstractMainTestClock.kt:67)
    at androidx.compose.ui.test.junit4.AndroidSynchronization_androidKt.runOnUiThread(AndroidSynchronization.android.kt:33)
    at androidx.compose.ui.test.junit4.MainTestClockImpl$1.invoke(MainTestClockImpl.android.kt:31)
    at androidx.compose.ui.test.junit4.MainTestClockImpl$1.invoke(MainTestClockImpl.android.kt:31)
    at androidx.compose.ui.test.junit4.AbstractMainTestClock.advanceDispatcher(AbstractMainTestClock.kt:67)
    at androidx.compose.ui.test.junit4.AbstractMainTestClock.advanceTimeByFrame(AbstractMainTestClock.kt:38)
    at androidx.compose.ui.test.junit4.ComposeIdlingResource.isIdleNow(ComposeIdlingResource.android.kt:57)
    at androidx.compose.ui.test.junit4.IdlingResourceRegistry.areAllResourcesIdle(IdlingResourceRegistry.jvm.kt:125)
    at androidx.compose.ui.test.junit4.IdlingResourceRegistry.isIdleOrEnsurePolling$ui_test_junit4_release(IdlingResourceRegistry.jvm.kt:104)
    at androidx.compose.ui.test.junit4.EspressoLink.isIdleNow(EspressoLink.android.kt:45)
    at androidx.test.espresso.base.IdlingResourceRegistry.allResourcesAreIdle(IdlingResourceRegistry.java:4)
    at androidx.test.espresso.base.IdlingResourceRegistry$6.isIdleNow(IdlingResourceRegistry.java:1)
    at androidx.test.espresso.base.UiControllerImpl.loopMainThreadUntilIdle(UiControllerImpl.java:11)
    at androidx.test.espresso.Espresso$1.run(Espresso.java:1)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at android.os.Handler.handleCallback(Handler.java:883)
    at android.os.Handler.dispatchMessage(Handler.java:100)
    at android.os.Looper.loop(Looper.java:214)
    at android.app.ActivityThread.main(ActivityThread.java:7356)

2022-02-17 10:25:30.793 3699-3699/com.test.gestures W/System.err:     at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Minimal reproducer:

@Test
fun recomposing_simple() {
    var state by mutableStateOf(0)
    rule.setContent {
        val parentContext = rememberCompositionContext()
        val composition = remember {
            Composition(UiApplier(LayoutNode()), parentContext)
                .apply {
                    setContent {
                        // force apply changes on state modification
                        key(state) {
                            Box(Modifier)
                        }
                    }
                }
        }

        if (state > 0) {
            LaunchedEffect(Unit) {
                composition.setContent {
                    Box(Modifier)
                }
                state++
            }
        }
    }

    rule.runOnIdle {
        state++
    }

    rule.waitUntil { state == 2 }
}

The issue is caused by subcomposition trying to composeInitial inside applyChanges call of parent. recompose loop causes subcomposition to be in invalid state (pendingModifications set to PendingApplyNoModifications), which is usually cleared by applyChanges. In this case, however, applyChanges of subcomposition is yet to be called, causing the crash when inserting new content into subcomposition.

Triage notes, we still haven't been able to reliably reproduce this internally however we think this is a valid bug that we should fix.

We have an ignored failing test with the repro: forceMeasureOfInactiveElementFromLaunchedEffect

Triage notes: We'll try to take a look at this and distinguish it from some other outstanding bugs.

Not sure if its Compose 1.7 or moving to Kotlin 2.0 and the new compiler plugin but started seeing that same lazylist stack hitting hit around the time we made those 2 upgrades

We think that some occurrences of this issue are fixed as part of b/382094412. This may address some of the +1's on this issue, but likely not all of them.

The test in comment#10, while @Ignore-d, is passing locally. I'm not sure we have another reproduction case here. If anyone is able to come up with a new one, please send it our way. We'd like to investigate further.