Take `--release` flag into account when setting up JavaCompile task [188389628]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

May 17, 2021 09:48AM

AGP should take value of javaCompile.options.release into account when setting up compilation:

using --release 8 should not be allowed as it does not allow AGP to change -bootclasspath param value
for 9+, using release should be ok, but AGP should also check value for -source/-target

Original issue: https://issuetracker.google.com/185418460

Comments

bi...@google.com <bi...@google.com> May 18, 2021 08:02AM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #2Sep 26, 2022 08:02PM

Is this fixed? I'm still seeing this issue with AGP 8.1.0-beta01 + Gradle 8.1

ga...@google.com <ga...@google.com> #3Sep 27, 2022 12:08PM

The fix has not been landed.

Message last modified on Sep 27, 2022 12:08PM

bi...@google.com <bi...@google.com> #4Sep 27, 2022 07:26PM

Due to this bug in CI we hit configuration cache invalidation 100% of the time. Can we make sure the fix lands soon? And especially before 8.1.0 stable.

Message last modified on Sep 27, 2022 07:27PM

ga...@google.com <ga...@google.com> #5Sep 27, 2022 10:18PM

I cc'ed you on the CL which should be landed this week.

bi...@google.com <bi...@google.com> #6Sep 28, 2022 12:08AM

Aurimas, is this 8.1 blocking for Androidx? If not, feel free to remove the "Blocking release" label.

ga...@google.com <ga...@google.com> #7Sep 28, 2022 09:44AM

cherry pick to G is landed.

bi...@google.com <bi...@google.com> #8Sep 28, 2022 03:34PM

This was still broken when running lint, but that is fixed here, which will be included in AGP 8.2.0-alpha10.

TBD if it will be included in 8.1.0 and/or 8.1.1

ga...@google.com <ga...@google.com> #9Sep 28, 2022 08:51PM

Reassigning to Xav to review CP to 8.1 branch

bi...@google.com <bi...@google.com> #10Sep 30, 2022 07:44PM

Marked as fixed.

Scott, do we have a cherry-pick ready for the lint fix?