Take `--release` flag into account when setting up JavaCompile task [188389628]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

May 17, 2021 09:48AM

AGP should take value of javaCompile.options.release into account when setting up compilation:

using --release 8 should not be allowed as it does not allow AGP to change -bootclasspath param value
for 9+, using release should be ok, but AGP should also check value for -source/-target

Original issue: https://issuetracker.google.com/185418460

Comments

bi...@google.com <bi...@google.com> May 18, 2021 08:02AM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #2Sep 26, 2022 08:02PM

I also have the same issue so it seems to be a real problem.

ga...@google.com <ga...@google.com> #3Sep 27, 2022 12:08PM

Dup here:

http://code.google.com/p/android/issues/detail?id=27959&can=1&q=fixed%20position&colspec=ID%20Type%20Status%20Owner%20Summary%20Stars

Though it's a bit more detailed with the minimum necessary to reproduce.

Message last modified on Sep 27, 2022 12:08PM

bi...@google.com <bi...@google.com> #4Sep 27, 2022 07:26PM

why is this marked has Obsolete? this is still a bug that is happening and its difficult to fix.
for all who are looking for a solution use this:

http://stackoverflow.com/questions/16200972/android-css-positionfixed-after-a-device-rotate

Message last modified on Sep 27, 2022 07:27PM

ga...@google.com <ga...@google.com> #5Sep 27, 2022 10:18PM

Users should interact with AGP using DSL/API. Configuring tasks directly is not supported. See how we handle other error/warning reporting.

bi...@google.com <bi...@google.com> #6Sep 28, 2022 12:08AM

Yeah, configuring task directly should no longer be supported. But https://b.corp.google.com/issues/185418460#comment4 seems to be configuring task directly?

ga...@google.com <ga...@google.com> #7Sep 28, 2022 09:44AM

What happens if release is set to 9, but source/target are not set? What is the error message for release = 9 and source/target set to 8? Should we improve it?

Do we need to evaluate value of release option during configuration (it is a property)? If we can continue having everything lazy, then doing checks in doFirst makes sense. If we need to get the actual value, then it makes sense to have these checks in configuration phase.

bi...@google.com <bi...@google.com> #8Sep 28, 2022 03:34PM

The expectation from javac is that if you set release, then don't set -source/-target. If you set release to 9 and -source/-target to 8, then javac would complain about using them together.(not about the version being not in sync)

I am still confused about whether users can configure JavaCompile task directly, can you confirm?

ga...@google.com <ga...@google.com> #9Sep 28, 2022 08:51PM

I am still confused about whether users can configure JavaCompile task directly, can you confirm?

Users can configure JavaCompile directly (it is just a property on the task).

Considering the main goal of -release is to replace -source/-target/-bootclasspath, it may make sense to discourage its usage in Android project. We can add a warning (asking users to avoid specifying it), and then turn that into an error at some point. What do you think?

bi...@google.com <bi...@google.com> #10Sep 30, 2022 07:44PM

Marked as fixed.

Fixed with Icf5adc2c469b8af68205ccd8aea377c9295834d6