Layout inspection for AppCompat shadowed attributes [188446121]

Fixed

Feature Request

Status Update

No update yet.

Description

em...@google.com

created issue #1

May 17, 2021 07:55PM

Layout inspector support for attributes shadowed by appcompat, e.g.: androidx.appcompat:backgroundTint shadows android:backgroundTint.

Comments

ap...@google.com <ap...@google.com> #2May 17, 2021 09:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d46999fa005b4726287814ea0f8abe30cf189a01
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue May 26 15:36:06 2020

Clean up ActivityResultCaller implementation

Instead of using two separate anonymous classes to be returned by the
register methods, lets clean it up by using an internal class and only
doing the implementation once.

Test: Tested in app
Bug: 156875743
Change-Id: Ia63dd0dce4ecd7115ea93168f889e119738e3352

M activity/activity-ktx/api/1.2.0-alpha06.txt
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_1.2.0-alpha06.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
M activity/activity-ktx/api/restricted_1.2.0-alpha06.txt
M activity/activity-ktx/api/restricted_current.txt
M activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultCaller.kt

https://android-review.googlesource.com/1318046

em...@google.com <em...@google.com> May 17, 2021 09:46PM

Accepted by em...@google.com.

ap...@google.com <ap...@google.com> #3May 17, 2021 11:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 55c784def8b9942026075af6fc659b551732ef44
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue May 26 08:45:51 2020

Add getContract to ActivityResultLauncher

Intents provide a way to check if the intent can be handled by any
Activity components and the ActivityResultLauncher should provide
the ability to do something similar.

This change adds a getContract API to ActivityResultLauncher that gives
the returns the contract used to register the launcher. This means that
users can create an Intent from their contract and make all of their
desired checks.

Test: ActivityResultLauncherTest
Bug: 156875743
RelNote: "ActivityResultLauncher now allows you to get the
ActivityResultContract that was used to register the launcher."

Change-Id: I64f536f2b3dde3e87cea884c6b9c111e5efe26ed

M activity/activity-ktx/build.gradle
M activity/activity-ktx/src/androidTest/AndroidManifest.xml
A activity/activity-ktx/src/androidTest/java/androidx/activity/result/ActivityResultCallerTest.kt
M activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultCaller.kt
M activity/activity/api/1.2.0-alpha06.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha06.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha06.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultLauncherTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultLauncher.java
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java

https://android-review.googlesource.com/1317916

ap...@google.com <ap...@google.com> #4May 18, 2021 09:00PM

This has been fixed internally and will be available in the Activity 1.2.0-alpha06 release.

To address this the ActivityResultLauncher now gives access to the ActivityResultContract.

With the contract, you can create the intent and use it to call resolveActivity() directly:

launcher.contract.createIntent(context, input).resolveActivity(packageManager)

ap...@google.com <ap...@google.com> #5May 18, 2021 10:23PM

Keep in mind that due to the Package visibility changes in Android 11, by default, resolveActivity() will return null unless you add the specific <queries> elements to your manifest.

As per that doc, the alternative is to catch the ActivityNotFoundException yourself by wrapping your launch() call in a try / catch, just like if you were using startActivityForResult() yourself.

ap...@google.com <ap...@google.com> #6May 18, 2021 10:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 575674b572525f2ae8626306eab2a2cd264a7246
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 17:53:29 2021

Covert test dependencies to runtime only

Compile testing needs these dependencies to be on the runtime
classpath, but they're not needed on the implementation classpath.
(All use is in source strings or code generated in the test itself.)
This keeps the implementation classpath clean.

Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I0332d8049a3fb0e22b7565d9f98cc56a8dbe3783

M resourceinspection/resourceinspection-processor/build.gradle

https://android-review.googlesource.com/1711049

em...@google.com <em...@google.com> #7May 20, 2021 09:00PM

Marked as fixed.

This should be available in appcompat:1.4.0-alpha02 and resourceinpsection:1.0.0-alpha02

ap...@google.com <ap...@google.com> #8May 21, 2021 05:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1bc6fdbb39da2551ddbf94e3d96ff3cd35c8779d
Author: Ember Rose <emberrose@google.com>
Date: Thu May 20 16:36:24 2021

Resourece Inspection 1.0.0-alpha02

Test: N/A
Bug: 188446121
Change-Id: I76330dac3210b000842ad8151d8cd2ddf9f2227a

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt

https://android-review.googlesource.com/1714294