Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
em...@google.com <em...@google.com>
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 12:31:44 2021
Document shadowed attribute interfaces
Test: N/A (docs)
Bug: 188446121
Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75
M core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
https://android-review.googlesource.com/1711028
Branch: androidx-main
commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 12:31:44 2021
Document shadowed attribute interfaces
Test: N/A (docs)
Bug: 188446121
Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75
M core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 575674b572525f2ae8626306eab2a2cd264a7246
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 17:53:29 2021
Covert test dependencies to runtime only
Compile testing needs these dependencies to be on the runtime
classpath, but they're not needed on the implementation classpath.
(All use is in source strings or code generated in the test itself.)
This keeps the implementation classpath clean.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I0332d8049a3fb0e22b7565d9f98cc56a8dbe3783
M resourceinspection/resourceinspection-processor/build.gradle
https://android-review.googlesource.com/1711049
Branch: androidx-main
commit 575674b572525f2ae8626306eab2a2cd264a7246
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 17:53:29 2021
Covert test dependencies to runtime only
Compile testing needs these dependencies to be on the runtime
classpath, but they're not needed on the implementation classpath.
(All use is in source strings or code generated in the test itself.)
This keeps the implementation classpath clean.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I0332d8049a3fb0e22b7565d9f98cc56a8dbe3783
M resourceinspection/resourceinspection-processor/build.gradle
em...@google.com <em...@google.com> #7
This should be available in appcompat:1.4.0-alpha02 and resourceinpsection:1.0.0-alpha02
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit 1bc6fdbb39da2551ddbf94e3d96ff3cd35c8779d
Author: Ember Rose <emberrose@google.com>
Date: Thu May 20 16:36:24 2021
Resourece Inspection 1.0.0-alpha02
Test: N/A
Bug: 188446121
Change-Id: I76330dac3210b000842ad8151d8cd2ddf9f2227a
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
https://android-review.googlesource.com/1714294
Branch: androidx-main
commit 1bc6fdbb39da2551ddbf94e3d96ff3cd35c8779d
Author: Ember Rose <emberrose@google.com>
Date: Thu May 20 16:36:24 2021
Resourece Inspection 1.0.0-alpha02
Test: N/A
Bug: 188446121
Change-Id: I76330dac3210b000842ad8151d8cd2ddf9f2227a
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
Description
Layout inspector support for attributes shadowed by appcompat, e.g.:
androidx.appcompat:backgroundTint
shadowsandroid:backgroundTint
.