Layout inspection for AppCompat shadowed attributes [188446121]

Fixed

Feature Request

Status Update

No update yet.

Description

em...@google.com

created issue #1

May 17, 2021 07:55PM

Layout inspector support for attributes shadowed by appcompat, e.g.: androidx.appcompat:backgroundTint shadows android:backgroundTint.

Comments

ap...@google.com <ap...@google.com> #2May 17, 2021 09:14PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

em...@google.com <em...@google.com> May 17, 2021 09:46PM

Accepted by em...@google.com.

ap...@google.com <ap...@google.com> #3May 17, 2021 11:40PM

Great! Thanks a lot, I'll look for the live updates soon!

ap...@google.com <ap...@google.com> #4May 18, 2021 09:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 49d18d3f7b42f7a5675357bd51fa4ff22ac0b5d5
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 18:51:33 2021

Shadowed attributes annotation processing

Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: Icf4eb2cab92ccde42daf583566f0ce7aca6d6d34

M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
M resourceinspection/resourceinspection-processor/src/test/kotlin/androidx/resourceinspection/processor/ResourceInspectionProcessorTest.kt

https://android-review.googlesource.com/1709968

ap...@google.com <ap...@google.com> #5May 18, 2021 10:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 12:31:44 2021

Document shadowed attribute interfaces

Test: N/A (docs)
Bug: 188446121
Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75

M core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java

https://android-review.googlesource.com/1711028

ap...@google.com <ap...@google.com> #6May 18, 2021 10:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 575674b572525f2ae8626306eab2a2cd264a7246
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 17:53:29 2021

Covert test dependencies to runtime only

Compile testing needs these dependencies to be on the runtime
classpath, but they're not needed on the implementation classpath.
(All use is in source strings or code generated in the test itself.)
This keeps the implementation classpath clean.

Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I0332d8049a3fb0e22b7565d9f98cc56a8dbe3783

M resourceinspection/resourceinspection-processor/build.gradle

https://android-review.googlesource.com/1711049

em...@google.com <em...@google.com> #7May 20, 2021 09:00PM

Marked as fixed.

This should be available in appcompat:1.4.0-alpha02 and resourceinpsection:1.0.0-alpha02

ap...@google.com <ap...@google.com> #8May 21, 2021 05:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1bc6fdbb39da2551ddbf94e3d96ff3cd35c8779d
Author: Ember Rose <emberrose@google.com>
Date: Thu May 20 16:36:24 2021

Resourece Inspection 1.0.0-alpha02

Test: N/A
Bug: 188446121
Change-Id: I76330dac3210b000842ad8151d8cd2ddf9f2227a

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt

https://android-review.googlesource.com/1714294