Allow easily pass additional data to ViewModelProvider.Factory.create() [188541057]

Fixed

Feature Request

Status Update

No update yet.

Description

se...@google.com

created issue #1

May 18, 2021 05:04PM

Currently ViewModelProvider.Factory.create receives only Class as parameter. If a factory needs an additional information (e.g SavedStateViewModelFactory), it should be passed into the constructor of that factory. As a result,

factory becomes stateful;
in general it makes things harder, because you have to have this information during injection time;
factory can be incorrectly reused if factory is bound to wrong scope (e.g. not matching ViewModelStoreOwner and SavedStateRegistryOwner);

Comments

ap...@google.com <ap...@google.com> #2Sep 26, 2021 08:30PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

em...@gmail.com <em...@gmail.com> #3Oct 5, 2021 10:37PM

چرا زبان فارسی و را در رایانه ها وگوشی تلفن هوایی نیست

ap...@google.com <ap...@google.com> #4Oct 7, 2021 01:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit b9404701c6bcc101d2cd64bb788b35def45b24b4
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Oct 06 12:25:25 2021

Remove KeyedFactory

SavedStateVMFactories don't rely on KeyedFactory anymore
and use CreationExtras infra instead.

Lifecycles are atomic group, so it is binary compatible change
because KeyedFactory was restricted API.

bug: 188541057
Relnote: NA
Test: ./gradlew :life:lifec-viewm-savedst:cC
Change-Id: Iaa409d87a555d1647832eab33f78151e62706e6d

M lifecycle/lifecycle-viewmodel-savedstate/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/AbstractSavedStateViewModelFactory.java
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
A lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateViewModelFactory.java
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt

https://android-review.googlesource.com/1846223

ap...@google.com <ap...@google.com> #5Oct 17, 2021 12:15PM

Project: platform/frameworks/support
Branch: androidx-main

commit ca3a75330b198ea068bc25d965597f72e719d8f5
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Oct 14 16:44:56 2021

Add stateless version of AndroidViewModelFactory

Relnote: """
Empty constructor for AndroidViewModelFactory
AndroidViewModelFactory.APPLICATION_KEY were added.
"""
bug: 188541057
Test: AndroidViewModelFactoryTest

Change-Id: Ie30b93fe6c4e89c3c03a2f16c63001ea18dce60a

M lifecycle/lifecycle-viewmodel/api/current.txt
A lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/AndroidViewModelFactoryTest.kt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt

https://android-review.googlesource.com/1857646

ap...@google.com <ap...@google.com> #6Oct 17, 2021 12:15PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5c60b72b50c807153e196cd565fe0a703a86b616
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Oct 08 17:05:47 2021

Create SavedStateHandle in AbstractSavedStateViewModelFactory from CreationExtras

This makes possible empty constructor of AbstractSavedStateViewModelFactory.
Then this constructor is used, AbstractSavedStateViewModelFactory is stateless.

Relnote: """SavedStateHandle can be created directly from
CreationExtras passed into the ViewModelProvider.Factory
if extras contain all required information"""
bug: 188541057
Test: SavedStateHandleSupportTest

Change-Id: Ia6654a36eff3c71dc45dbf35e447d1efe24b5b4b

M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleController.java
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/viewmodel/CreationExtras.kt
M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleSupportTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateViewModelFactory.java
M lifecycle/lifecycle-viewmodel-savedstate/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/AbstractSavedStateViewModelFactory.java
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
A lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt
A lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/LegacySavedStateHandleController.java
M lifecycle/lifecycle-viewmodel/src/test/java/androidx/lifecycle/ViewModelProviderTest.java
M lifecycle/lifecycle-viewmodel/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/HasDefaultViewModelProviderFactory.java

https://android-review.googlesource.com/1853518

ap...@google.com <ap...@google.com> #7Oct 19, 2021 09:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit 034cf037b22e333758f387becaa933635f307afe
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Oct 15 19:14:49 2021

Add stateless version of SavedStateViewModelFactory

Relnote: """
Empty constructor for SavedStateViewModelFactory, that creates
a stateless version of SavedStateViewModelFactory, that is safe
to reuse.
"""
bug: 188541057
Test: SavedStateFactoryTest / ViewModelsWithStateTest

Change-Id: I5d22411aecbd2e8e3d8a259fc4eff4afaa42ee21

A lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/TestComponent.kt
M lifecycle/lifecycle-viewmodel-savedstate/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateFactoryTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleSupportTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateViewModelFactory.java

https://android-review.googlesource.com/1859226

se...@google.com <se...@google.com> Oct 19, 2021 05:20PM

Verified by se...@google.com.

se...@google.com <se...@google.com> Oct 19, 2021 07:59PM

Marked as fixed.

am...@gmail.com <am...@gmail.com> #8Nov 20, 2021 12:29PM

Has this been released?

ge...@gmail.com <ge...@gmail.com> #9Jan 28, 2022 12:08AM

Reaching here due:

https://github.com/google/dagger/issues/2328#issuecomment-955170443

db...@gmail.com <db...@gmail.com> #10Feb 11, 2022 12:15PM

https://issuetracker.google.com/188541057