Safe-Args (Kotlin) 2.4.0-alpha01 incorrect generation [188564435]

Fixed

Bug

Status Update

No update yet.

Description

ih...@gmail.com

created issue #1

May 19, 2021 11:21AM

Component used: Navigation

Version used: 2.4.0-alpha01

After update Navigation from 2.3.5 to 2.4.0-alpha01 I received this errors:

e: /Users/ihor/Documents/Projects/omni-app-android/app/build/generated/source/navigation-args/gms/debug/ru/omni/android/app/NavigationCasesDetailDirections.kt: (29, 12): 'getArguments' overrides nothing

e: /Users/ihor/Documents/Projects/omni-app-android/app/build/generated/source/navigation-args/gms/debug/ru/omni/android/app/NavigationCasesDetailDirections.kt: (26, 12): 'getActionId' overrides nothing

e: /Users/ihor/Documents/Projects/omni-app-android/app/build/generated/source/navigation-args/gms/debug/ru/omni/android/app/NavigationCasesDetailDirections.kt: (20, 16): Class 'ActionGlobalAssignGroup' is not abstract and does not implement abstract member public abstract val actionId: Int defined in androidx.navigation.NavDirections

I think it because Safe-Args plugin codegen not updated to new structure of NavDirections (Kotlin val`s instead methods)

Comments

ac...@gmail.com <ac...@gmail.com> #2May 19, 2021 02:18PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

il...@google.com <il...@google.com> May 19, 2021 04:37PM

Assigned to jb...@google.com.

sh...@gmail.com <sh...@gmail.com> #3May 20, 2021 10:48PM

I can confirm this.

Firstly, thank you! Finally we get the multi stack support. I tried 2.4.0-alpha01 but failed to compile. All the generated Actionxxxxx class for my nav actions with arguments are having error "Class 'Actionxxxxx' is not abstract and does not implement abstract member public abstract val actionId: Int defined in androidx.navigation.NavDirections".

ap...@google.com <ap...@google.com> #4May 21, 2021 03:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit d05079ecf245da3356cfd24023ce5ccc7328f37a
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu May 20 10:23:36 2021

Fix safe args directions class generation

Since navigaiton is now is Kotlin, the safe args kotlin plugin needs to
override the property instead of getter methods since the getters don't
exist in kotlin.

RelNote: "Safe Args no longer crashes when attempting to generate
direction functions in kotlin with Navigation 2.4.0-alpha01"
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 188564435

Change-Id: Id2416d7d7c52888fb9ec9bdbb80afcc7d2a1bf3e

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentDirections.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/Next.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsDirections.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsDirections.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/kotlin/nested_same_action/SettingsDirections.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/kotlin/nested_same_action/SettingsFragmentDirections.kt

https://android-review.googlesource.com/1714508

il...@google.com <il...@google.com> #5May 21, 2021 08:02PM

Marked as fixed.

This has been fixed for Navigation 2.4.0-alpha02.

ed...@googlemail.com <ed...@googlemail.com> #6Jun 5, 2021 07:04PM

I am unfortunately still seeing this as part of Navigation 2.4.0-alpha02

./gradlew :app:dependencies | grep navigation
+--- androidx.navigation:navigation-fragment-ktx:2.4.0-alpha02
|    \--- androidx.navigation:navigation-fragment:2.4.0-alpha02
|         +--- androidx.navigation:navigation-runtime:2.4.0-alpha02
|         |    +--- androidx.navigation:navigation-common:2.4.0-alpha02

The error I see is similar in nature to previously mentioned:

Class 'ActionHomeFragmentToDetailFragment' is not abstract and does not implement abstract member public abstract val actionId: Int defined in androidx.navigation.NavDirections e: HomeFragmentDirections.kt: (19, 12): 'getActionId' overrides nothing e: HomeFragmentDirections.kt: (22, 12): 'getArguments' overrides nothing

The source for this HomeFragmentDirections.kt is attached - if you need any further details please let me know

For reference, reverting to use the 'androidx.navigation.safeargs' instead of 'androidx.navigation.safeargs.kotlin' resolved this issue

HomeFragmentDirections.kt

1.4 KB

Download

tp...@gmail.com <tp...@gmail.com> #7Jun 7, 2021 10:00AM

Working fine for me upgrading to 2.4.0-alpha02 made the generated actionId a val instead of a fun

public override val actionId: Int = R.id.action_leaderboard_to_userProfile

Did you happen to change androidx.navigation:navigation-safe-args-gradle-plugin to 2.4.0-alpha02 as well?

zh...@gmail.com <zh...@gmail.com> #8Jun 9, 2021 07:27AM

Don't forget to clean/build after gradle sync

je...@gmail.com <je...@gmail.com> #9May 12, 2023 03:19AM

Comment has been deleted.

Message last modified on May 12, 2023 03:20AM

pa...@gmail.com <pa...@gmail.com> #10May 12, 2023 03:31AM

the first gmail