Status Update
No update yet.
Comments
ac...@gmail.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
il...@google.com
sh...@gmail.com
ap...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
il...@google.com
This has been fixed for Navigation 2.4.0-alpha02.
ed...@googlemail.com
I am unfortunately still seeing this as part of Navigation 2.4.0-alpha02
./gradlew :app:dependencies | grep navigation
+--- androidx.navigation:navigation-fragment-ktx:2.4.0-alpha02
| \--- androidx.navigation:navigation-fragment:2.4.0-alpha02
| +--- androidx.navigation:navigation-runtime:2.4.0-alpha02
| | +--- androidx.navigation:navigation-common:2.4.0-alpha02
The error I see is similar in nature to previously mentioned:
Class 'ActionHomeFragmentToDetailFragment' is not abstract and does not implement abstract member public abstract val actionId: Int defined in androidx.navigation.NavDirections e: HomeFragmentDirections.kt: (19, 12): 'getActionId' overrides nothing e: HomeFragmentDirections.kt: (22, 12): 'getArguments' overrides nothing
The source for this HomeFragmentDirections.kt is attached - if you need any further details please let me know
For reference, reverting to use the 'androidx.navigation.safeargs' instead of 'androidx.navigation.safeargs.kotlin' resolved this issue
tp...@gmail.com
Working fine for me upgrading to 2.4.0-alpha02 made the generated actionId a val instead of a fun
public override val actionId: Int = R.id.action_leaderboard_to_userProfile
Did you happen to change androidx.navigation:navigation-safe-args-gradle-plugin to 2.4.0-alpha02 as well?
zh...@gmail.com
Don't forget to clean/build after gradle sync
Description
Component used: Navigation
Version used: 2.4.0-alpha01
After update Navigation from 2.3.5 to 2.4.0-alpha01 I received this errors:
I think it because Safe-Args plugin codegen not updated to new structure of NavDirections (Kotlin val`s instead methods)