Status Update
Comments
ac...@gmail.com <ac...@gmail.com> #2
il...@google.com <il...@google.com>
sh...@gmail.com <sh...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
ap...@google.com <ap...@google.com> #4
il...@google.com <il...@google.com> #5
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ed...@googlemail.com <ed...@googlemail.com> #6
I am unfortunately still seeing this as part of Navigation 2.4.0-alpha02
./gradlew :app:dependencies | grep navigation
+--- androidx.navigation:navigation-fragment-ktx:2.4.0-alpha02
| \--- androidx.navigation:navigation-fragment:2.4.0-alpha02
| +--- androidx.navigation:navigation-runtime:2.4.0-alpha02
| | +--- androidx.navigation:navigation-common:2.4.0-alpha02
The error I see is similar in nature to previously mentioned:
Class 'ActionHomeFragmentToDetailFragment' is not abstract and does not implement abstract member public abstract val actionId: Int defined in androidx.navigation.NavDirections e: HomeFragmentDirections.kt: (19, 12): 'getActionId' overrides nothing e: HomeFragmentDirections.kt: (22, 12): 'getArguments' overrides nothing
The source for this HomeFragmentDirections.kt is attached - if you need any further details please let me know
For reference, reverting to use the 'androidx.navigation.safeargs' instead of 'androidx.navigation.safeargs.kotlin' resolved this issue
tp...@gmail.com <tp...@gmail.com> #7
Working fine for me upgrading to 2.4.0-alpha02 made the generated actionId a val instead of a fun
public override val actionId: Int = R.id.action_leaderboard_to_userProfile
Did you happen to change androidx.navigation:navigation-safe-args-gradle-plugin to 2.4.0-alpha02 as well?
zh...@gmail.com <zh...@gmail.com> #8
Don't forget to clean/build after gradle sync
Description
Component used: Navigation
Version used: 2.4.0-alpha01
After update Navigation from 2.3.5 to 2.4.0-alpha01 I received this errors:
I think it because Safe-Args plugin codegen not updated to new structure of NavDirections (Kotlin val`s instead methods)