RippleDrawable implementation of Compose ripple sometimes crashes with NullPointerException: null cannot be cast to non-null type android.view.View [188569367]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

May 19, 2021 05:19AM

Jetpack Compose release version: 1.0.0-beta07 Android Studio Build: 7.1.0-alpha01

It seems that in some cases the new RippleDrawable-backed ripple implementation in beta07 crashes.

I haven't figured out what the exact conditions required are to get the ripple to crash, but you should be able to reproduce the crash by checking out the zachklipp/repro-ripple-bug branch of the compose-richtext repository from GitHub and running the sample app (there's only one app in the project).

The stack trace starts as follows (full trace attached):

java.lang.NullPointerException: null cannot be cast to non-null type android.view.View
    at androidx.compose.material.ripple.PlatformRipple.findNearestViewGroup(Ripple.android.kt:115)
    at androidx.compose.material.ripple.PlatformRipple.rememberUpdatedRippleInstance-942rkJo(Ripple.android.kt:78)
    at androidx.compose.material.ripple.Ripple.rememberUpdatedInstance(Ripple.kt:125)
    at androidx.compose.foundation.IndicationKt$indication$2.invoke(Indication.kt:108)
    at androidx.compose.foundation.IndicationKt$indication$2.invoke(Indication.kt:106)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:73)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:68)
    at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
    at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:46)
    at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
    at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
    at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:68)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:74)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:68)
    at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
    at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:46)
    at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:68)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:74)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:68)
    at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
    at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:46)
    at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
    at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:68)
    at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke-Deg8D_g(Layout.kt:174)
    at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke(Layout.kt:173)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:116)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)

stacktrace.txt

35 KB

View

Download

Comments

ma...@google.com <ma...@google.com> May 19, 2021 11:15AM

Assigned to lp...@google.com.

lp...@google.com <lp...@google.com> #2May 19, 2021 01:47PM

If a bottom sheet is in a half expanded state and recreated into a screen where half expanded isn't possible (because it isn't tall enough) it crashes with the same error.

This is also an issue in pre 1.4.0-alpha04, but the error message is "The initial value must have an associated anchor".

This is easily reproducible by having a bottom sheet with a height that in landscape has half expanded, but doesn't in portrait. When rotating with the sheet open it always crashes. This can be mitigated by disallowing the bottom sheet to be half expanded by creating the bottom sheet state with rememberModalBottomSheetState(initialValue = ModalBottomSheetValue.Hidden, skipHalfExpanded = true)

za...@gmail.com <za...@gmail.com> #3May 19, 2021 09:15PM

Thanks for the report. Do you have an isolated repro?

ap...@google.com <ap...@google.com> #4May 25, 2021 12:30PM

Marked as fixed.

You do - apologies, I missed that. We'll check it out! :)

Issue 188569367

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> May 19, 2021 11:15AM

lp...@google.com <lp...@google.com> #2May 19, 2021 01:47PM

za...@gmail.com <za...@gmail.com> #3May 19, 2021 09:15PM

ap...@google.com <ap...@google.com> #4May 25, 2021 12:30PM

Add comment

Issue metadata