RippleDrawable implementation of Compose ripple sometimes crashes with NullPointerException: null cannot be cast to non-null type android.view.View [188569367]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

May 19, 2021 05:19AM

Jetpack Compose release version: 1.0.0-beta07 Android Studio Build: 7.1.0-alpha01

It seems that in some cases the new RippleDrawable-backed ripple implementation in beta07 crashes.

I haven't figured out what the exact conditions required are to get the ripple to crash, but you should be able to reproduce the crash by checking out the zachklipp/repro-ripple-bug branch of the compose-richtext repository from GitHub and running the sample app (there's only one app in the project).

The stack trace starts as follows (full trace attached):

java.lang.NullPointerException: null cannot be cast to non-null type android.view.View
    at androidx.compose.material.ripple.PlatformRipple.findNearestViewGroup(Ripple.android.kt:115)
    at androidx.compose.material.ripple.PlatformRipple.rememberUpdatedRippleInstance-942rkJo(Ripple.android.kt:78)
    at androidx.compose.material.ripple.Ripple.rememberUpdatedInstance(Ripple.kt:125)
    at androidx.compose.foundation.IndicationKt$indication$2.invoke(Indication.kt:108)
    at androidx.compose.foundation.IndicationKt$indication$2.invoke(Indication.kt:106)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:73)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:68)
    at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
    at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:46)
    at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
    at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
    at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:68)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:74)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:68)
    at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
    at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:46)
    at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:68)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:74)
    at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:68)
    at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
    at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:46)
    at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
    at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:68)
    at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke-Deg8D_g(Layout.kt:174)
    at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke(Layout.kt:173)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:116)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)

stacktrace.txt

35 KB

View

Download

Comments

ma...@google.com <ma...@google.com> May 19, 2021 11:15AM

Assigned to lp...@google.com.

lp...@google.com <lp...@google.com> #2May 19, 2021 01:47PM

The problem here seems to be that you are manually overriding LocalView, which is what ripple uses to add the ripple views to the hierarchy:

https://github.com/zach-klippenstein/compose-richtext/blob/zachklipp/repro-ripple-bug/sample/src/main/java/com/zachklipp/richtext/sample/ScreenPreview.kt#L74. If I uncomment this line it no longer seems to crash.

Maybe we should have a fallback to use the 'software' rendering in case the view isn't attached properly, but this will result in jank because the ripples will be animated on the ui thread - so you still probably want to provide a valid view in LocalView.

za...@gmail.com <za...@gmail.com> #3May 19, 2021 09:15PM

Ah, well this is admittedly a pretty weird thing for me to be doing, so it's probably not even worth worrying about too much. I can probably rewrite that code anyway, it's pretty gross. Thanks!

ap...@google.com <ap...@google.com> #4May 25, 2021 12:30PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit bebb27ff8269be3f487047a1ad9acf63be4ae052
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon May 24 18:07:43 2021

Removes LocalRippleNativeRendering

Also adds an explicit error message if the view used to attach a RippleContainer to is not attached properly.

Fixes:

b/188569367

Test: updateApi
Relnote: "Removed LocalRippleNativeRendering now that the View-backed ripple implementation is stable"
Change-Id: I7fab3b12f34b82741c562ae8af3b2d08fbbb47c7

M compose/material/material-ripple/api/1.0.0-beta08.txt
A compose/material/material-ripple/api/current.ignore
M compose/material/material-ripple/api/current.txt
M compose/material/material-ripple/api/public_plus_experimental_1.0.0-beta08.txt
M compose/material/material-ripple/api/public_plus_experimental_current.txt
M compose/material/material-ripple/api/restricted_1.0.0-beta08.txt
A compose/material/material-ripple/api/restricted_current.ignore
M compose/material/material-ripple/api/restricted_current.txt
D compose/material/material-ripple/src/androidAndroidTest/kotlin/androidx/compose/material/ripple/LocalRippleNativeRenderingTest.kt
M compose/material/material-ripple/src/androidMain/kotlin/androidx/compose/material/ripple/Ripple.android.kt

https://android-review.googlesource.com/1716911

Issue 188569367

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> May 19, 2021 11:15AM

lp...@google.com <lp...@google.com> #2May 19, 2021 01:47PM

za...@gmail.com <za...@gmail.com> #3May 19, 2021 09:15PM

ap...@google.com <ap...@google.com> #4May 25, 2021 12:30PM

Add comment

Issue metadata