Status Update
No update yet.
Comments
wu...@google.com
ch...@google.com
With the change of lifecycle-common to KMP, we might be able to just move this into the right spot (since it'll mirror the same structure as lifecycle-runtime, which does work).
ma...@google.com
lifecycle-common even after conversion to KMP is still a jar. We do not want to change that to an AAR as that is a breaking change for consumers, so i dont think we can make it work this project.
ch...@google.com
Ah yeah good point.
sc...@google.com
Branch: androidx-main
commit a00e293b59bdbe5746941171fe793b863aaafabe
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Apr 11 15:42:42 2024
Move baseline-prof.txt from Lifecycle common to runtime
* Move `baseline-prof.txt` from `lifecycle-common` to `lifecycle-runtime`;
* Because there are multiple files now in `lifecycle-runtime`, group them inside a `baselineProfiles` folder.
* Rename the files to match what modules they target.
Test: N/A
Fixes: 322382422
Change-Id: Iaced653d78e6fe6c107e389ed76cd3ca37e46347
D lifecycle/lifecycle-common/src/jvmMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt
ma...@google.com
Hi Scott. Yes, that's the main benefit.
sc...@google.com
We are finalizing the API design and implementing it.
ap...@google.com
Branch: androidx-main
commit d06334462e1b0b027ecd289cbd53d807ff6fb73e
Author: Charcoal Chen <charcoalchen@google.com>
Date: Thu Jun 03 13:44:44 2021
Expose getResolutionInfo API to provide the resolution information for use cases
Relnote: "Exposed getResolutionInfo API to provide the resloution information for Preview, ImageCapture and ImageAnalysis."
Bug: 188600718
Test: ./gradlew camera:camera-core:build && ./gradlew camera:camera-core:connectedAndroidTest
Change-Id: I2b61350f38bafa40862c923077d9da2675f16905
M camera/camera-core/api/current.txt
M camera/camera-core/api/public_plus_experimental_current.txt
M camera/camera-core/api/restricted_current.txt
M camera/camera-core/src/androidTest/java/androidx/camera/core/ImageCaptureTest.java
M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysis.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
A camera/camera-core/src/main/java/androidx/camera/core/ResolutionInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
ch...@google.com
Hi Max,
A new getResolutionInfo API has been exposed from CameraX by aosp/1727613. You can use it to obtain the more precise resolution and crop rectangle information which should match the captured image dimensions after applying the rotation degrees. It means the following values will be the same:
- The resolution obtained from ResolutionInfo#getCropRect() after applying the value obtained from ResolutionInfo#getRotationDegrees().
- The saved image's dimensions after applying the Exif orientation value
On most devices, HAL doesn't directly rotate the image buffer to the target rotation orientation. But on few devices, the captured image might still have been rotated to the target rotation orientation by HAL. Therefore, in the case of your application, you might still need to double check the dimensions of the captured image and correct the database record.
ma...@google.com
Thanks for adding the API so quickly, Charcoal!
Description
Add a new API to expose the resolution used by each use cases.
The API should return the actual resolution used in the use cases after bindToLifecycle is called.