Inconsistent behavior with material transitions across fragment versions [188679569]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

May 19, 2021 06:29PM

Component used: Fragment

Version used: 1.3.4

Devices/Android versions reproduced on: Pixel 3 running Android 11

Sample project: https://github.com/tfcporciuncula/playground/tree/transition-issue (branch transition-issue)

I've learned from this codelab that transitionGroup=true can be important in some cases, even when no shared element is involved in the transition, and from my experience it usually makes my Material motion fragment transitions (e.g. MaterialSharedAxis) look better.

Starting from fragment 1.3.4, most likely because of this change, whether I have transitionGroup=true or not doesn't make a difference anymore, and now I have to set a transitionName instead to get the same effect I used to get with transitionGroup=true.

I'm attaching two videos, both recorded with fragment 1.3.4 and transition 1.4.1, and you can compare the difference between running a material shared axis transition with and without a transitionName defined. There are no shared elements involved in the transition, but defining or not a transitionName in the root of the fragment layouts have a big impact in the transitions, and that seems to be wrong.

with-transition-name.mov

3.8 MB

Download

without-transition-name.mov

1.9 MB

Download

Comments

il...@google.com <il...@google.com> May 20, 2021 04:26PM

Assigned to jb...@google.com.

ti...@gmail.com <ti...@gmail.com> #2May 21, 2021 12:13AM

Please upgrade to Preference 1.1.1 which contains the fix for this issue.

il...@google.com <il...@google.com> #3May 21, 2021 12:33AM

I am using Preference 1.1.1 already, as demonstrated in the sample project. In fact, I also reported 150051716, the one that is marked as duplicate. That issue is indeed fixed but this is a new one. The stacktrace is different too.

gm...@gmail.com <gm...@gmail.com> #4May 21, 2021 12:52PM

Yep, you're right. Looks like the root cause of this separate issue was already fixed by aosp/1181309 so upgrading to any Fragment 1.3.0 version would pull in the fix.

That fix is part of a much larger set of changes so I don't think it'll be possible for us to safely cherry pick that fix into a Fragment 1.2.X release, unfortunately.

I'll leave this open while we investigate what that would take.

jb...@google.com <jb...@google.com> #5May 21, 2021 03:33PM

My apologies for not trying the latest alpha release beforehand. Upgrading to version 1.3.0 solves my case. Thank you for pointing that out.

gm...@gmail.com <gm...@gmail.com> #6May 22, 2021 08:45AM

When using fragment-ktx:1.3.0-alpha03, I'm still able to reproduce this issue. The following crash occurs on a configuration change:

java.lang.IllegalStateException: Fragment androidx.fragment.app.Fragment$4@5ff632e does not have a view
    at androidx.fragment.app.Fragment$4.onFindViewById(Fragment.java:2711)
    at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:464)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1170)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1316)
    at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1394)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1460)
    at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2695)
    at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2644)
    at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:2784)
    at androidx.fragment.app.FragmentStateManager.activityCreated(FragmentStateManager.java:507)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1171)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1316)
    at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1394)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1460)
    at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2695)
    at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2644)
    at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:251)
    at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:546)
    at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:201)
    at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1392)
    at android.app.Activity.performStart(Activity.java:7172)
    at android.app.ActivityThread.handleStartActivity(ActivityThread.java:2967)
    at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:180)
    at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:165)
    at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:142)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:70)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1816)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:193)
    at android.app.ActivityThread.main(ActivityThread.java:6854)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:860)

TestTransition.zip

141 KB

Download

de...@gmail.com <de...@gmail.com> #7May 28, 2021 08:18AM

Thanks, this looks like an issue with DialogFragment so fixing that underlying issue should fix PreferenceDialogFragmentCompat as well.

animation_correct_fragment133.mp4

2.5 MB

Download

animation_incorrect_fragment134.mp4

345 KB

Download

eu...@gmail.com <eu...@gmail.com> #8May 31, 2021 04:35AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3c698888435fee8af2d911e54d1b9df9fd46648c
Author: Ian Lake <ilake@google.com>
Date: Tue Apr 21 16:46:50 2020

Fix onFindViewById in DialogFragment

Instead of only considering the Fragment's view,
DialogFragment should also consider the Dialog's
view when calling onFindViewById(). This ensures
that any <fragment> or FragmentContainerView that
is created as part of the Dialog's view structure
will properly be reattached to its view hierarchy
after a configuration change.

Test: updated DialogFragmentInflatedChildTest tests pass
BUG: 154366601
Change-Id: I59ada3193974f00ab4df475d992e237baa03c5bf

M fragment/fragment/src/androidTest/java/androidx/fragment/app/DialogFragmentInflatedChildTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1292291

ve...@gmail.com <ve...@gmail.com> #9Jun 2, 2021 10:28AM

This has been fixed internally and will be available in Fragment 1.3.0-alpha04.

You can confirm the fix in your project by following the snapshot instructions at androidx.dev, using a buildId of 6419956 and Fragment 1.3.0-SNAPSHOT.

tf...@gmail.com <tf...@gmail.com> #10Jun 2, 2021 02:11PM

That was quick! It works as expected now. Much appreciated

sm...@gmail.com <sm...@gmail.com> #11Jun 8, 2021 06:09PM

There is a regression introduced in 1.3.4 with transitionGroup=true. I posted the exact code that should be fixed in this ticket:

https://issuetracker.google.com/issues/188569366

ti...@gmail.com <ti...@gmail.com> #12Jun 9, 2021 08:52PM

On: kotlin 1.5.0 gradle plugin 7.1.0-alpha02 fragment 1.3.0 appcompat 1.3.0-beta01 activity 1.3.0-alpha03 navigation 2.4.0-alpha02

The issue suddenly started to occur again (I tried updating fragment before), but I just updated the gradle plugin and navigation.

de...@gmail.com <de...@gmail.com> #13Jun 9, 2021 09:12PM

Thats because appcompat > rc01 depends in Fragment 1.3.4

ap...@google.com <ap...@google.com> #14Jun 9, 2021 11:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 06769a572f7003fb662109b595952d6ff5c63a74
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 08 16:35:28 2021

Fix fragment transitions in new state manager

In aosp/1679887 we attempted to fix doing shared element transitions on
ViewGroups with the transitionGroup="false" attribute set. That change
caused a regression in enter and exit transitions, and could also cause
errors if the entering fragment attempted to transition more views than
the exiting fragment.

This change makes it so that fragments no longer looks at all of the
views in the hierarchy of sharedelement views. We depend on transition
names to determine if a view is a shared element, and if a shared
element is a viewgroup with transitionGroup="true", the entering/exiting
transition should ignore that viewgroup and transition its unnamed
children.

RelNote: "Fixed regression in shared element transtions caused by
aosp/1679887. Setting transitionGroup=\"true\" will now work correctly and
shared elements will no longer throw `IndexOutOfBoundsException`s."
Test: FragmentSharedElementTransitionTest
Bug: 188679569
Bug: 188969304

Change-Id: I164845639cae1f64cf54e4e89b2a24d7eb649beb

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentSharedElementTransitionTest.kt
A fragment/fragment/src/androidTest/res/layout/scene6.xml
A fragment/fragment/src/androidTest/res/layout/scene7.xml
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1732732

jb...@google.com <jb...@google.com> #15Jun 10, 2021 01:50AM

Marked as fixed.

This has been fixed internally and will be part of the Fragment 1.4.0-alpha03 release. You can verify that it works with your app by following the instructions at androidx.dev to enable SNAPSHOTs and using a buildId of 7444280+.

os...@gmail.com <os...@gmail.com> #16Jun 11, 2021 11:31AM

I had the crash starting from 1.3.4 on animation SharedAxis:

java.lang.UnsupportedOperationException: removeView(View) is not supported in AdapterView
    at android.widget.AdapterView.removeView(AdapterView.java:543)
    at android.view.ViewOverlay$OverlayViewGroup.add(ViewOverlay.java:198)
    at android.view.ViewGroupOverlay.add(ViewGroupOverlay.java:72)
    at androidx.transition.TransitionUtils.createViewBitmap(TransitionUtils.java:108)
    at androidx.transition.TransitionUtils.copyViewImage(TransitionUtils.java:64)
    at androidx.transition.Visibility.onDisappear(Visibility.java:404)
    at androidx.transition.Visibility.createAnimator(Visibility.java:257)
    at androidx.transition.Transition.createAnimators(Transition.java:744)
    at androidx.transition.TransitionSet.createAnimators(TransitionSet.java:480)
    at androidx.transition.TransitionSet.createAnimators(TransitionSet.java:480)
    at androidx.transition.Transition.playTransition(Transition.java:1808)
    at androidx.transition.TransitionManager$MultiListener.onPreDraw(TransitionManager.java:300)
    at android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:1088)
    at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2769)
    at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1745)
    at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7772)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:967)
    at android.view.Choreographer.doCallbacks(Choreographer.java:791)
    at android.view.Choreographer.doFrame(Choreographer.java:726)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:952)
    at android.os.Handler.handleCallback(Handler.java:883)
    at android.os.Handler.dispatchMessage(Handler.java:100)
    at android.os.Looper.loop(Looper.java:214)
    at android.app.ActivityThread.main(ActivityThread.java:7356)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:940)

But it disappeared on 1.4.0-SNAPSHOT starting from 7444280. Is this crash relates to this issue? And will it be included to 1.3.5?
Thanks!

gm...@gmail.com <gm...@gmail.com> #17Jul 2, 2021 02:26PM

Seems to be fixed in 1.3.5, thanks!

Issue 188679569

Description

Issue summary

Comments

il...@google.com <il...@google.com> May 20, 2021 04:26PM

ti...@gmail.com <ti...@gmail.com> #2May 21, 2021 12:13AM

il...@google.com <il...@google.com> #3May 21, 2021 12:33AM

gm...@gmail.com <gm...@gmail.com> #4May 21, 2021 12:52PM

jb...@google.com <jb...@google.com> #5May 21, 2021 03:33PM

gm...@gmail.com <gm...@gmail.com> #6May 22, 2021 08:45AM

de...@gmail.com <de...@gmail.com> #7May 28, 2021 08:18AM

eu...@gmail.com <eu...@gmail.com> #8May 31, 2021 04:35AM

ve...@gmail.com <ve...@gmail.com> #9Jun 2, 2021 10:28AM

tf...@gmail.com <tf...@gmail.com> #10Jun 2, 2021 02:11PM

sm...@gmail.com <sm...@gmail.com> #11Jun 8, 2021 06:09PM

ti...@gmail.com <ti...@gmail.com> #12Jun 9, 2021 08:52PM

de...@gmail.com <de...@gmail.com> #13Jun 9, 2021 09:12PM

ap...@google.com <ap...@google.com> #14Jun 9, 2021 11:46PM

jb...@google.com <jb...@google.com> #15Jun 10, 2021 01:50AM

os...@gmail.com <os...@gmail.com> #16Jun 11, 2021 11:31AM

gm...@gmail.com <gm...@gmail.com> #17Jul 2, 2021 02:26PM

Add comment

Issue metadata